Opened 3 years ago
Closed 3 years ago
#28668 closed defect (fixed)
fix the base_ring of face_split
Reported by: | gh-LaisRast | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.0 |
Component: | geometry | Keywords: | polytopes, face_split, base_ring |
Cc: | jipilab, gh-kliem | Merged in: | |
Authors: | Laith Rastanawi | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 2a4249e (Commits, GitHub, GitLab) | Commit: | 2a4249eb6421f87baf5534c70ff473a876bf0abb |
Dependencies: | Stopgaps: |
Description
The base_ring
of face_split
should be self.base_ring().fraction_field()
.
sage: P = polytopes.octahedron() sage: P.face_split(P.faces(2)[0]) --------------------------------------------------------------------------- TypeError Traceback (most recent call last) ... TypeError: no conversion of this rational to integer
Change History (7)
comment:1 Changed 3 years ago by
- Branch set to public/28668
- Commit set to 5ea47b80872ee04d4839645e9321702f74b5a197
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
please add a doctest
comment:3 Changed 3 years ago by
- Commit changed from 5ea47b80872ee04d4839645e9321702f74b5a197 to 3fe3152d2251bedf600813df8712b150486f3365
Branch pushed to git repo; I updated commit sha1. New commits:
3fe3152 | add a doctest to face_split
|
comment:4 Changed 3 years ago by
bad sphinx syntax for the doctest. Write TESTS: and do not indent
comment:5 Changed 3 years ago by
- Commit changed from 3fe3152d2251bedf600813df8712b150486f3365 to 2a4249eb6421f87baf5534c70ff473a876bf0abb
Branch pushed to git repo; I updated commit sha1. New commits:
2a4249e | fix doctest syntax
|
comment:6 Changed 3 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, then
comment:7 Changed 3 years ago by
- Branch changed from public/28668 to 2a4249eb6421f87baf5534c70ff473a876bf0abb
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
fix face_split base_ring