Opened 2 years ago

Closed 2 years ago

#28663 closed enhancement (fixed)

remove deprecated stuff in padics

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.0
Component: refactoring Keywords:
Cc: caruso, roed, saraedum, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw, David Roe
Report Upstream: N/A Work issues:
Branch: 3726356 (Commits, GitHub, GitLab) Commit: 3726356507d7f2c573b968ede9a8eec8ba8ad7de
Dependencies: Stopgaps:

Status badges

Description

after #14825

Change History (9)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/28663
  • Cc caruso roed saraedum added
  • Commit set to bae385dd17277ef0c83230717acb47c5768ab689
  • Status changed from new to needs_review

New commits:

bae385dremove deprecated stuff in padics

comment:2 Changed 2 years ago by chapoton

  • Cc tscrim added

green bot, please review (easy one)

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 2 years ago by roed

  • Status changed from positive_review to needs_work

I'm fine with these changes, but if we're going to remove the expansion deprecations for padic_ZZ_pX_CA_element we should really do it for the others too.

padics$ git grep "14825"
local_generic_element.pyx:            See http://trac.sagemath.org/14825 for details.
padic_ZZ_pX_CA_element.pyx:            deprecation(14825, "Interface to expansion has changed; first argument now n")
padic_ZZ_pX_CA_element.pyx:    list = deprecated_function_alias(14825, expansion)
padic_ZZ_pX_CA_element.pyx:    teichmuller_list = deprecated_function_alias(14825, teichmuller_expansion)
padic_ZZ_pX_CR_element.pyx:            deprecation(14825, "Interface to expansion has changed; first argument now n")
padic_ZZ_pX_CR_element.pyx:    list = deprecated_function_alias(14825, expansion)
padic_ZZ_pX_CR_element.pyx:    teichmuller_list = deprecated_function_alias(14825, teichmuller_expansion)
padic_ZZ_pX_FM_element.pyx:            deprecation(14825, "Interface to expansion has changed; first argument now n")
padic_ZZ_pX_FM_element.pyx:    list = deprecated_function_alias(14825, expansion)
padic_ZZ_pX_FM_element.pyx:    teichmuller_list = deprecated_function_alias(14825, teichmuller_expansion)
padic_generic_element.pyx:            See http://trac.sagemath.org/14825 for details.
padic_generic_element.pyx:        deprecation(14825, "__getitem__ is changing to match the behavior of number fields. Please use expansion instead.")
padic_template_element.pxi:            See http://trac.sagemath.org/14825 for details.
padic_template_element.pxi:        deprecation(14825, "list is deprecated. Please use expansion instead.")
padic_template_element.pxi:            See http://trac.sagemath.org/14825 for details.
padic_template_element.pxi:        deprecation(14825, "teichmuller_list is deprecated. Please use teichmuller_expansion instead.")
padic_template_element.pxi:            See http://trac.sagemath.org/14825 for details.
padic_template_element.pxi:        deprecation(14825, "padded_list is deprecated.  Please use expansion or Integer.digits with the padto keyword instead.")

comment:5 Changed 2 years ago by git

  • Commit changed from bae385dd17277ef0c83230717acb47c5768ab689 to 3726356507d7f2c573b968ede9a8eec8ba8ad7de

Branch pushed to git repo; I updated commit sha1. New commits:

3726356remove more deprecated stuff from 14825

comment:6 Changed 2 years ago by chapoton

ok. Done. I have left the ones concerning "getitem" aside, as they seem to warn about some future change, not yet in sage.

Last edited 2 years ago by chapoton (previous) (diff)

comment:7 Changed 2 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:8 Changed 2 years ago by roed

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, David Roe
  • Status changed from needs_review to positive_review

Yeah, I think leaving __getitem__ alone until we make the change mentioned there seems fine. Looks good to me.

comment:9 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/28663 to 3726356507d7f2c573b968ede9a8eec8ba8ad7de
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.