#28662 closed defect (fixed)

Missing edges when visualizing Polyhedra with threejs

Reported by: jipilab Owned by:
Priority: major Milestone: sage-9.0
Component: graphics Keywords: threejs, polyhedron, polytope
Cc: dimpase, paulmasson, egourgoulhon Merged in:
Authors: Paul Masson Reviewers: Eric Gourgoulhon, Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: ca23e0f (Commits, GitHub, GitLab) Commit: ca23e0f8fa73968407de31e7c102b34dfbb043e6
Dependencies: Stopgaps:

Status badges

Description

When visualizing polyhedra with threejs, the edges are missing:

sage: p = polytopes.icosahedron()
sage: p.plot()
Launched html viewer for Graphics3d Object 

but

sage: icosahedron()

seems to have the edges.

Change History (6)

comment:1 Changed 18 months ago by paulmasson

  • Branch set to u/paulmasson/28662

comment:2 Changed 18 months ago by paulmasson

  • Authors set to Paul Masson
  • Commit set to ca23e0f8fa73968407de31e7c102b34dfbb043e6
  • Status changed from new to needs_review

During the cleanup while adding mesh plots I overlooked this index that needed to be changed. Oops!


New commits:

ca23e0fFix addLine()

comment:3 follow-up: Changed 18 months ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

Thanks for the fix! LGTM.

comment:4 in reply to: ↑ 3 Changed 18 months ago by jipilab

Replying to egourgoulhon:

Thanks for the fix! LGTM.

+1

Thanks for the quick fix!

comment:5 Changed 18 months ago by egourgoulhon

  • Reviewers changed from Eric Gourgoulhon to Eric Gourgoulhon, Jean-Philippe Labbé

comment:6 Changed 18 months ago by vbraun

  • Branch changed from u/paulmasson/28662 to ca23e0f8fa73968407de31e7c102b34dfbb043e6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.