Opened 3 years ago

Closed 2 years ago

#28654 closed defect (fixed)

A Bug in the backend `field`

Reported by: gh-LaisRast Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes, fields, empty, lines
Cc: jipilab, gh-kliem, vdelecroix Merged in:
Authors: Jonathan Kliem Reviewers: Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: b8543fe (Commits, GitHub, GitLab) Commit: b8543feda019c2b350da32fa811e86c2c17b1352
Dependencies: #17339 Stopgaps:

Status badges

Description (last modified by gh-kliem)

The backend field have the following bug:

sage: Polyhedron(lines=[[1]], backend='field')
The empty polyhedron in QQ^1

This is fixed by fixing #17339. We add a doctest verifying the fix.

Change History (5)

comment:1 Changed 3 years ago by gh-kliem

  • Cc vdelecroix added

It seems to be related to #17339.

When one tries to fix this, the verification that checks

Polyhedron(ieqs=[], ambient_dim=1) == Polyhedron(lines=[[1]])

in the class Hrep2Vrep in will fail.

comment:2 Changed 2 years ago by gh-kliem

  • Authors set to Jonathan Kliem
  • Dependencies set to #17339
  • Description modified (diff)
  • Status changed from new to needs_review

comment:3 Changed 2 years ago by gh-kliem

  • Branch set to public/28654
  • Commit set to b8543feda019c2b350da32fa811e86c2c17b1352

New commits:

b8543febackend field treats polyhedra that are universe correctly

comment:4 Changed 2 years ago by gh-LaisRast

  • Reviewers set to Laith Rastanawi
  • Status changed from needs_review to positive_review

#17339 fixed the problem. Since #17339 is on positive review, this also should be on positive review.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from public/28654 to b8543feda019c2b350da32fa811e86c2c17b1352
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.