Opened 2 years ago

Closed 2 years ago

#28621 closed enhancement (fixed)

Add CombinatorialPolyhedron method to Polyhedron objects

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes, combinatorial polyhedron
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: b89610e (Commits, GitHub, GitLab) Commit: b89610e0a70bdde272d632ef1d7972941ab19311
Dependencies: Stopgaps:

Status badges

Description (last modified by jipilab)

Implement a method that returns the combinatorial polyhedron object of a polyhedron.

Change History (8)

comment:1 Changed 2 years ago by gh-kliem

  • Branch set to public/28621
  • Cc jipilab gh-LaisRast added
  • Commit set to b89610e0a70bdde272d632ef1d7972941ab19311
  • Keywords polytopes combinatorial polyhedron added
  • Status changed from new to needs_review

New commits:

​b89610eadded combinatorial polyhedron as an attribute for polyhedra

comment:2 Changed 2 years ago by jipilab

  • Description modified (diff)
  • Summary changed from Add CombinatorialPolyehdron to Polyhedron to Add CombinatorialPolyhedron method to Polyhedron objects

comment:3 Changed 2 years ago by gh-LaisRast

  • Status changed from needs_review to positive_review

Looks good.

comment:4 Changed 2 years ago by gh-LaisRast

  • Reviewers set to Laith Rastanawi

comment:5 Changed 2 years ago by git

  • Commit changed from b89610e0a70bdde272d632ef1d7972941ab19311 to acd671d2d21c0a2eda565d8f9281d88a1f046233
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​326602cf_vector of CombinatorialPolyhedron is a vector
​dfbe2adMerge branch 'public/28607' of git://trac.sagemath.org/sage into public/28621
​ed5518bused CombinatorialPolyhedron to compute f_vector
​9bdd005give an error message for polytopes in some cases; removed incorrect example
​acd671dnow we get a precice error message for inexact truncated dodecahedron

comment:6 Changed 2 years ago by git

  • Commit changed from acd671d2d21c0a2eda565d8f9281d88a1f046233 to b89610e0a70bdde272d632ef1d7972941ab19311

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:7 Changed 2 years ago by gh-LaisRast

  • Status changed from needs_review to positive_review

comment:8 Changed 2 years ago by vbraun

  • Branch changed from public/28621 to b89610e0a70bdde272d632ef1d7972941ab19311
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.