Opened 2 years ago

Last modified 2 years ago

#28614 closed enhancement

CombinatorialPolyhedron: length_* to n_* — at Version 7

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes, combinatorial polyhedron
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: public/28614 (Commits, GitHub, GitLab) Commit: c03065126194dc15a8222a7ea32a6c8c800a40b4
Dependencies: #28605 Stopgaps:

Status badges

Description (last modified by gh-kliem)

To make CombinatorialPolyhedron more consistent with Polyhedron we change the following names.

  • length_Hrepr -> n_Hrepresentation
  • length_Vrepr -> n_Vrepresentation

In FaceIterator:

  • length_atom_repr -> n_atom_rep (note that #28608 changes repr to rep)

In CombinatorialFace:

  • length_Vrepr -> n_ambient_Vrepresentation
  • length_Hrepr -> n_ambient_Hrepresentation

As both methods are public we keep the old methods with deprecation warnings.

As a follow up in #28615 we need to fix the alignment in src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

Change History (7)

comment:1 Changed 2 years ago by gh-kliem

  • Description modified (diff)

comment:2 Changed 2 years ago by gh-kliem

  • Description modified (diff)

comment:3 Changed 2 years ago by gh-kliem

  • Description modified (diff)

comment:4 Changed 2 years ago by gh-kliem

  • Branch set to public/28614
  • Commit set to 2bddb974048a483e869d03e5018efda5c70f5beb

New commits:

d597ed3replace attributes by methods
2fc4fe0removed empty folder being created in source
37592f9replace attributes by methods; remove empty folder from source
e865f9dremoved attribute Vinv, as its not being used
84ef31badded docstrings to the new methods
588afa4removed method for Vinv
2bddb97length_* -> n_

comment:5 Changed 2 years ago by git

  • Commit changed from 2bddb974048a483e869d03e5018efda5c70f5beb to c03065126194dc15a8222a7ea32a6c8c800a40b4

Branch pushed to git repo; I updated commit sha1. New commits:

c030651deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

comment:6 Changed 2 years ago by gh-kliem

  • Cc jipilab gh-LaisRast added
  • Description modified (diff)
  • Keywords polytopes combinatorial polyhedron added
  • Status changed from new to needs_review

New commits:

c030651deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

comment:7 Changed 2 years ago by gh-kliem

  • Description modified (diff)
Note: See TracTickets for help on using tickets.