Opened 2 years ago

Last modified 2 years ago

#28614 closed enhancement

CombinatorialPolyhedron: length_* to n_* — at Version 1

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes, combinatorial polyhedron
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #28605 Stopgaps:

Status badges

Description (last modified by gh-kliem)

To make CombinatorialPolyhedron more consistent with Polyhedron we change the following names.

length_Hrepr -> n_Hrepresentation length_Vrepr -> n_Vrepresentation

In FaceIterator: length_atom_repr -> n_atom_rep (note that #28608 changes repr to rep)

In CombinatorialFace: length_Vrepresentation -> n_ambient_Vrepresentation

As a follow up we need to fix the alignment in src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

Change History (1)

comment:1 Changed 2 years ago by gh-kliem

  • Description modified (diff)
Note: See TracTickets for help on using tickets.