Changes between Version 3 and Version 6 of Ticket #28614


Ignore:
Timestamp:
10/16/19 07:51:45 (2 years ago)
Author:
gh-kliem
Comment:

New commits:

c030651deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28614

    • Property Status changed from new to needs_review
    • Property Cc jipilab gh-LaisRast added
    • Property Branch changed from to public/28614
    • Property Keywords polytopes combinatorial polyhedron added
    • Property Commit changed from to c03065126194dc15a8222a7ea32a6c8c800a40b4
  • Ticket #28614 – Description

    v3 v6  
    99In `CombinatorialFace`:
    1010- `length_Vrepr` -> `n_ambient_Vrepresentation`
     11- `length_Hrepr` -> `n_ambient_Hrepresentation`
     12As both methods are public we keep the old methods with deprecation warnings.
    1113
    1214As a follow up we need to fix the alignment in `src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd`. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.