Changes between Version 1 and Version 2 of Ticket #28614


Ignore:
Timestamp:
10/16/19 07:23:02 (2 years ago)
Author:
gh-kliem
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28614 – Description

    v1 v2  
    11To make `CombinatorialPolyhedron` more consistent with `Polyhedron` we change the following names.
    22
    3 `length_Hrepr` -> `n_Hrepresentation`
    4 `length_Vrepr` -> `n_Vrepresentation`
     3- `length_Hrepr` -> `n_Hrepresentation`
     4- `length_Vrepr` -> `n_Vrepresentation`
    55
    66In `FaceIterator`:
    7 `length_atom_repr` -> `n_atom_rep` (note that #28608 changes `repr` to `rep`)
     7- `length_atom_repr` -> `n_atom_rep` (note that #28608 changes `repr` to `rep`)
    88
    99In `CombinatorialFace`:
    10 `length_Vrepresentation` -> `n_ambient_Vrepresentation`
     10- `length_Vrepresentation` -> `n_ambient_Vrepresentation`
    1111
    1212As a follow up we need to fix the alignment in `src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd`. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.