Opened 3 years ago
Closed 2 years ago
#28608 closed enhancement (fixed)
CombinatorialPolyhedron: abbrevations Hrepr -> Hrep etc.
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | geometry | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jonathan Kliem | Reviewers: | Laith Rastanawi |
Report Upstream: | N/A | Work issues: | |
Branch: | 8fa61df (Commits, GitHub, GitLab) | Commit: | 8fa61df51cf595e5e4fe3afea4694112fa70931d |
Dependencies: | Stopgaps: |
Description (last modified by )
In Polyhedron the used abbreviation for representation is rep as in Hrep_generator
etc.
Accordingly, this abbreviation is adopted for CombinatorialPolyhedron
.
While we are at it we fix some instances of the typo representaion
.
We add a deprecation warning for the keyword Vrepr
of CombinatorialPolyhedron.__init__
.
We remove a redefinition of a deprecated method (n_Hrepr
of combinatorial face).
Change History (10)
comment:1 Changed 3 years ago by
- Branch set to public/28608
- Commit set to 07d0742b1b2053fb470340a16d20ce81981fc5d2
- Description modified (diff)
- Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 3 years ago by
- Dependencies changed from #28605 to #28605, #28616
comment:3 Changed 3 years ago by
- Description modified (diff)
comment:4 Changed 3 years ago by
- Dependencies changed from #28605, #28616 to #28605, #28616, #28614
- Description modified (diff)
comment:5 Changed 2 years ago by
- Milestone changed from sage-9.0 to sage-9.1
comment:6 Changed 2 years ago by
- Dependencies #28605, #28616, #28614 deleted
- Description modified (diff)
- Status changed from new to needs_review
comment:7 Changed 2 years ago by
- Commit changed from 07d0742b1b2053fb470340a16d20ce81981fc5d2 to 8fa61df51cf595e5e4fe3afea4694112fa70931d
comment:8 follow-up: ↓ 9 Changed 2 years ago by
- Reviewers set to Laith Rastanawi
It looks good to me. I will wait for the patchbot to test in on 9.1.beta4
comment:9 in reply to: ↑ 8 Changed 2 years ago by
- Status changed from needs_review to positive_review
Replying to gh-LaisRast:
It looks good to me. I will wait for the patchbot to test in on 9.1.beta4
Bots are green, so I'll set it to positive review.
comment:10 Changed 2 years ago by
- Branch changed from public/28608 to 8fa61df51cf595e5e4fe3afea4694112fa70931d
- Resolution set to fixed
- Status changed from positive_review to closed
Ticket retargeted after milestone closed