CombinatorialPolyhedron: unbounded -> is_bounded

[gh-kliem]

In order to make CombinatorialPolyhedron to be more consistent with standard naming conventions we replace the method unbounded by is_bounded and the attribute unbounded by bounded.

[gh-kliem]

New commits:

​d597ed3	replace attributes by methods
​2fc4fe0	removed empty folder being created in source
​37592f9	replace attributes by methods; remove empty folder from source
​e865f9d	removed attribute Vinv, as its not being used
​84ef31b	added docstrings to the new methods
​588afa4	removed method for Vinv
​531222d	unbounded(self) -> is_bounded(self); _unbounded -> _bounded

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​c8c49c5

fixed small mistake in header file

[gh-LaisRast]

Just a very small change: The docstring of is_bounded should now say:

      cdef bint is_bounded(self):
         r"""
-         Return whether the polyhedron is unbounded.
+         Return whether the polyhedron is bounded.
         """
         return self._bounded

[git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​326602c	f_vector of CombinatorialPolyhedron is a vector
​dfbe2ad	Merge branch 'public/28607' of git://trac.sagemath.org/sage into public/28621
​ed5518b	used CombinatorialPolyhedron to compute f_vector
​9bdd005	give an error message for polytopes in some cases; removed incorrect example
​acd671d	now we get a precice error message for inexact truncated dodecahedron
​bf85a62	subsequent calls for f_vector fail if first attempt fails
​dc99ea4	Merge branch 'public/28625' of git://trac.sagemath.org/sage into public/28605
​9b5bcaa	applied changes of 28605 to new code from 28625
​6fb97dc	Merge branch 'public/28605' of git://trac.sagemath.org/sage into public/28606
​846f216	small fix in doc

[gh-kliem]

Actually the last commit is a small fix in doc and applying the changes to #28625.

[jipilab]

Missing reviewer name

[jipilab]

There are failing doctests:

**********************************************************************
File "src/sage/misc/dev_tools.py", line 170, in sage.misc.dev_tools.load_submodules
Failed example:
    sage.misc.dev_tools.load_submodules(sage.geometry)
Expected:
    load sage.geometry.polyhedron.lattice_euclidean_group_element... succeeded
    load sage.geometry.polyhedron.palp_database... succeeded
    load sage.geometry.polyhedron.ppl_lattice_polygon... succeeded
Got:
    load sage.geometry.polyhedron.combinatorial_polyhedron.bit_vector_operations...failed
    load sage.geometry.polyhedron.lattice_euclidean_group_element... succeeded
    load sage.geometry.polyhedron.palp_database... succeeded
    load sage.geometry.polyhedron.ppl_lattice_polygon... succeeded
**********************************************************************

[gh-kliem]

This seems to be caused by #28605.

Just removing .cc to get rid of the empty folder doesn't seems to work.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​202cad9	replace attributes by methods
​2e3e464	removed empty folder being created in source
​7701062	removed attribute Vinv, as its not being used
​1b17f6e	added docstrings to the new methods
​c51cdd9	removed method for Vinv
​dd21f9c	applied changes of 28605 to new code from 28625
​4f49eac	undid change to module list
​6550083	unbounded(self) -> is_bounded(self); _unbounded -> _bounded

[gh-kliem]

Rebased it to #28605 so that there is only one commit now.

[gh-kliem]

Merge conflict

[gh-kliem]

New commits:

​0f3b121	replace attributes by methods; remove attribute Vinv
​8aaaef5	unbounded(self) -> is_bounded(self); _unbounded -> _bounded

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​b0eac08	replace attributes by methods; remove attribute Vinv
​e44a557	unbounded(self) -> is_bounded(self); _unbounded -> _bounded

[gh-kliem]

rebased

---

New commits:

​dd0729d	replace attributes by methods; remove attribute Vinv
​d4b3163	small fix in ridges
​c7da39d	unbounded(self) -> is_bounded(self); _unbounded -> _bounded

[jipilab]

Morally good to go.