Opened 2 years ago
Closed 2 years ago
#28578 closed enhancement (fixed)
Mixed Forms Code Improvements
Reported by:  ghDeRhamSource  Owned by:  

Priority:  major  Milestone:  sage9.0 
Component:  geometry  Keywords:  manifolds, mixed forms 
Cc:  tscrim, egourgoulhon  Merged in:  
Authors:  Michael Jung  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  449e1b4 (Commits, GitHub, GitLab)  Commit:  449e1b42f7a998c838a2c4c17a3e22005d32fd0d 
Dependencies:  #28579  Stopgaps: 
Description (last modified by )
Some code improvements in mixed_form.py
and mixed_form_algebra.py
.
This ticket is part of the metaticket #28519.
Change History (20)
comment:1 Changed 2 years ago by
 Cc tscrim egourgoulhon added
 Component changed from PLEASE CHANGE to geometry
 Dependencies set to #28579
 Description modified (diff)
 Keywords manifolds mixed forms added
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 2 years ago by
 Branch set to u/ghDeRhamSource/mixed_forms_code_improvements
comment:3 Changed 2 years ago by
 Commit set to 78a81b2c3615d431deb7f038f21886ce9bbdc5fc
comment:4 Changed 2 years ago by
 Commit changed from 78a81b2c3615d431deb7f038f21886ce9bbdc5fc to af0394ac9212cf13885ead4fc26a84aa1eb9adc9
Branch pushed to git repo; I updated commit sha1. New commits:
af0394a  Merge branch 'develop' into t/28578/mixed_forms_code_improvements

comment:5 Changed 2 years ago by
 Status changed from new to needs_info
Would you mind taking a short look whether the suggested changes are useful? Maybe, you have more things to improve in mind?
comment:6 Changed 2 years ago by
 Commit changed from af0394ac9212cf13885ead4fc26a84aa1eb9adc9 to cbb5251431bde7ad1a799391a5869971e452da64
Branch pushed to git repo; I updated commit sha1. New commits:
cbb5251  Doctests finished

comment:7 Changed 2 years ago by
 Commit changed from cbb5251431bde7ad1a799391a5869971e452da64 to 9694d1ca0d0465ce12c9649330ab90d060ddf1f9
Branch pushed to git repo; I updated commit sha1. New commits:
9694d1c  Speed up wedge using 'sum'

comment:8 Changed 2 years ago by
 Commit changed from 9694d1ca0d0465ce12c9649330ab90d060ddf1f9 to afebf2f873b74941ec61fd89330a955193f19d7f
Branch pushed to git repo; I updated commit sha1. New commits:
afebf2f  Redundant zero assignment removed in 'wedge'

comment:9 Changed 2 years ago by
 Commit changed from afebf2f873b74941ec61fd89330a955193f19d7f to d0b3af6927198aa9480a5d672d0814eb52b8a340
comment:10 Changed 2 years ago by
 Status changed from needs_info to needs_review
comment:11 Changed 2 years ago by
 Status changed from needs_review to needs_work
There are many doctest failures:
sage t long src/sage/manifolds/differentiable/mixed_form_algebra.py # 10 doctests failed sage t long src/sage/manifolds/differentiable/mixed_form.py # 125 doctests failed
comment:12 Changed 2 years ago by
 Commit changed from d0b3af6927198aa9480a5d672d0814eb52b8a340 to d63bf778cee34d97838f5ad6d9247abb8029a8f0
Branch pushed to git repo; I updated commit sha1. New commits:
d63bf77  Merge conflict with #28562

comment:13 Changed 2 years ago by
Ah yes, damn it. I fixed it during the merge into the metaticket #28519 and forgot to adapt it here, too. I'll perform a new doctest as soon as possible.
comment:14 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:15 Changed 2 years ago by
 Commit changed from d63bf778cee34d97838f5ad6d9247abb8029a8f0 to 7b291ca2229fdc634d90d5515d63d962e3810fb8
Branch pushed to git repo; I updated commit sha1. New commits:
7b291ca  With tensor fields consistent initialization of components

comment:16 Changed 2 years ago by
 Status changed from needs_review to needs_work
There is a merge conflict with Sage 9.0.beta4, in the file src/sage/manifolds/differentiable/mixed_form.py
.
comment:17 Changed 2 years ago by
 Commit changed from 7b291ca2229fdc634d90d5515d63d962e3810fb8 to 449e1b42f7a998c838a2c4c17a3e22005d32fd0d
comment:18 Changed 2 years ago by
 Status changed from needs_work to needs_review
We are already at beta4? Things are going fast... :D
comment:19 Changed 2 years ago by
 Reviewers set to Eric Gourgoulhon
 Status changed from needs_review to positive_review
LGTM.
comment:20 Changed 2 years ago by
 Branch changed from u/ghDeRhamSource/mixed_forms_code_improvements to 449e1b42f7a998c838a2c4c17a3e22005d32fd0d
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Typos fixed
Merge branch 't/28579/wedge_product_with_scalar_fields' into t/28578/mixed_forms_code_improvements