Opened 2 years ago

Closed 2 years ago

#28569 closed defect (fixed)

Internal links broken in poset catalog

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-9.0
Component: documentation Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: e4ec63a (Commits, GitHub, GitLab) Commit: e4ec63a21e7b643f88183168669ca3bd48f52f71
Dependencies: Stopgaps:

Status badges

Change History (8)

comment:1 Changed 2 years ago by gh-DaveWitteMorris

The links work for me (Firefox 69.0.2 on Mac OS 10.13.6).

comment:2 Changed 2 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/poset-ref-links

comment:3 Changed 2 years ago by jhpalmieri

  • Authors set to John Palmieri
  • Commit set to 1f67f2696a1f30f54bf8ad1cf29e2988cf5a46e6
  • Status changed from new to needs_review

I don't see the links either. Changing ~posets to ~Posets in each reference fixes it for me.


New commits:

1f67f26trac 28569: fix internal links in posets catalog

comment:4 Changed 2 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

Ah, that was it. Then also src/sage/categories/posets.py needs correction. Can you do that too in this ticket?

comment:5 Changed 2 years ago by jhpalmieri

I think those are actually different problems. sage/categories/posets.py just looks like a mistake, whereas sage/combinat/posets/poset_examples.py should have worked, since the file says posets = Posets at the bottom, and in a Sage session, posets.DiamondPoset() works. (In comparison, from the categories file, posets.ParentMethods... doesn't work.) Here is a fix for that file, too, though.

comment:6 Changed 2 years ago by git

  • Commit changed from 1f67f2696a1f30f54bf8ad1cf29e2988cf5a46e6 to e4ec63a21e7b643f88183168669ca3bd48f52f71

Branch pushed to git repo; I updated commit sha1. New commits:

e4ec63atrac 28569: fix internal Sphinx links in sage/categories/posets.py

comment:7 Changed 2 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Thanks, now this is good too.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/jhpalmieri/poset-ref-links to e4ec63a21e7b643f88183168669ca3bd48f52f71
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.