Changes between Version 1 and Version 2 of Ticket #28562, comment 25


Ignore:
Timestamp:
10/12/19 12:39:36 (2 years ago)
Author:
gh-DeRhamSource
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28562, comment 25

    v1 v2  
    55In the commits, there are two alternatives presented: One using a flag `check_elements` and one using a separate method without security check. I'd prefer the second solution. It is completely hidden for the user and may become convenient when more checks are established in the future.
    66
    7 I have another comment: I would suggest an outsourcing of some code snippets regarding `add_comp` and `set_comp` (and perhaps more). (Also I am not completely satisfied with my solution.) At this stage, most parts of the code are copied all over the place. I had to modify all of them separately and debugging was hell. I guess, an outsourcing would make future modifications, reuse and debugging much easier. Although, at the moment, I have no idea how to realize that.
     7I have another comment: I would suggest an outsourcing of some code snippets regarding `add_comp` and `set_comp` (and perhaps more). (Also, I am not completely satisfied with my solution.) At this stage, most parts of the code are copied all over the place. I had to modify all of them separately and debugging was hell. I guess, an outsourcing would make future modifications, reuse and debugging much easier. Although, at the moment, I have no idea how to realize that.