Opened 2 years ago

Closed 2 years ago

#28560 closed defect (fixed)

Ignore newlines in three.js version search

Reported by: arojas Owned by:
Priority: major Milestone: sage-9.0
Component: packages: standard Keywords:
Cc: isuruf, paulmasson Merged in:
Authors: Antonio Rojas Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6d8e131 (Commits, GitHub, GitLab) Commit: 6d8e1311f2b5dd6d477fecbf493bbd06e8c1348b
Dependencies: Stopgaps:

Status badges

Description (last modified by arojas)

The regexp-based version number search for three.js introduced in #28086 doesn't work for three.js version r109. The reason is that in the compiled three.min.js there is a line break right in the middle of the regexp match.

This patch strips newline characters from the file before extracting the version number

Change History (4)

comment:1 Changed 2 years ago by arojas

  • Branch set to u/arojas/ignore_newlines_in_three_js_version_search

comment:2 Changed 2 years ago by arojas

  • Authors set to Antonio Rojas
  • Cc isuruf paulmasson added
  • Commit set to 6d8e1311f2b5dd6d477fecbf493bbd06e8c1348b
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

6d8e131Strip newlines from three.min.js before extracting the version number

comment:3 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/arojas/ignore_newlines_in_three_js_version_search to 6d8e1311f2b5dd6d477fecbf493bbd06e8c1348b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.