Opened 13 years ago

Closed 13 years ago

#2856 closed enhancement (fixed)

[with patch, posititive review] PyLint unused variable cleanup for sage.rings.polynomial 2

Reported by: malb Owned by: cwitty
Priority: minor Milestone: sage-3.0
Component: misc Keywords: pylint
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

the usual stuff:

  • delete unused variables
  • remove unused imports

PS: After this patch, I'll get down to fixing real bugs again rather than introducing some via unforeseen sideeffects of these clean-ups :-)

Attachments (1)

pylint_polynomial_cleanup.patch (8.3 KB) - added by malb 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by malb

comment:1 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, needs review] PyLint unused variable cleanup for sage.rings.polynomial 2 to [with patch, posititive review] PyLint unused variable cleanup for sage.rings.polynomial 2

Patch applies cleanly and doctests fine. All changes are sane. +1 for PyLint?. Positive review.

Cheers,

Michael

comment:2 Changed 13 years ago by mabshoff

Merged in Sage 3.0.alpha3

comment:3 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.alpha3 and close the ticket ;)

Note: See TracTickets for help on using tickets.