Opened 3 years ago

Closed 3 years ago

#28556 closed defect (fixed)

fix word_problem()

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.0
Component: group theory Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f857f3b (Commits, GitHub, GitLab) Commit: f857f3b50f9436485ac2f284a38d046f46a29a85
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

sage: G = SymmetricGroup(6)
sage: s = G('(1,2,3)')
sage: s.word_problem?

The output does not explain the meaning of the parameters, is badly formatted, etc.

And the code was also wrong when the subgroup is not the full group, e.g.

s.word_problem([s])

should express s as a one-letter word over the generating set [s].

Initial report by Chase Meadors on sage-devel:

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/28556
  • Commit set to f857f3b50f9436485ac2f284a38d046f46a29a85
  • Component changed from documentation to group theory
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from fix documention for word_problem() to fix word_problem()

New commits:

f857f3btrac 28556 cleanup of word_problem

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by slelievre

  • Description modified (diff)

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28556 to f857f3b50f9436485ac2f284a38d046f46a29a85
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.