Opened 2 years ago

Closed 2 years ago

#28522 closed enhancement (fixed)

PolyhedralFan of Groebner fan is created twice

Reported by: jipilab Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: groebner
Cc: chapoton Merged in:
Authors: Jean-Philippe Labbé Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: bb66272 (Commits, GitHub, GitLab) Commit: bb662728360fefe4249eac320b8889405848ea15
Dependencies: Stopgaps:

Status badges

Description

When creating the PolyhedralFan? of a Gröbner fan, it is actually created twice. We fix this:

            f = self.gfan(cmd='topolyhedralfan', I=self._gfan_reduced_groebner_bases())
            self.__polyhedralfan = PolyhedralFan(f)
-           return PolyhedralFan(f)
+           return self.__polyhedralfan

Change History (3)

comment:1 Changed 2 years ago by jipilab

  • Status changed from new to needs_review

comment:2 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

Oui. Pas terrible.

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/jipilab/groebner to bb662728360fefe4249eac320b8889405848ea15
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.