Opened 2 years ago

Closed 22 months ago

#28507 closed defect (fixed)

MR37: Update symlinks in the docker -dev image

Reported by: galois Owned by:
Priority: major Milestone: sage-9.0
Component: docker Keywords: docker, ci
Cc: slelievre, nthiery, embray, roed, vdelecroix Merged in:
Authors: Julian Rüth Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: b26026f (Commits, GitHub, GitLab) Commit: b26026fae9017174a6f7fe471cd371e231d8a75a
Dependencies: #28502 Stopgaps:

Status badges

Description (last modified by slelievre)

Otherwise, when a library gets updated, it's .so is stale. This currently makes libpynac.so point to the wrong place in the non-released docker dev images on gitlab.

Change History (6)

comment:1 Changed 2 years ago by saraedum

  • Cc slelievre nthiery embray roed vdelecroix added
  • Component changed from PLEASE CHANGE to docker
  • Dependencies set to #28502
  • Description modified (diff)
  • Keywords docker ci added
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 2 years ago by saraedum

The CI passed. This is ready for review, except for the dependency, this is only this one commit:

https://git.sagemath.org/sage.git/commit/?h=b26026fae9017174a6f7fe471cd371e231d8a75a

comment:3 Changed 23 months ago by slelievre

  • Milestone changed from sage-8.9 to sage-9.0

Ticket #28502 was merged in Sage 9.0.beta5.

It would be nice to have this ticket in the next beta!

comment:4 Changed 22 months ago by saraedum

slelievre, feel free to review :)

comment:5 Changed 22 months ago by slelievre

  • Description modified (diff)
  • Reviewers set to Samuel Lelièvre
  • Status changed from needs_review to positive_review

Positive review.

comment:6 Changed 22 months ago by vbraun

  • Branch changed from u/galois/mrs/37/docker-sym to b26026fae9017174a6f7fe471cd371e231d8a75a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.