Opened 19 months ago

Closed 8 months ago

#28494 closed enhancement (duplicate)

Upgrade: rpy2 3.x

Reported by: isuruf Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: upgrade, rpy2
Cc: slelievre, charpent, gh-timokau, arojas, chapoton Merged in:
Authors: Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #28000 Stopgaps:

Status badges

Description

conda is already in 3.1.0

Change History (11)

comment:1 Changed 19 months ago by isuruf

Looks like rpy2 has dropped python2 support in recent versions

comment:2 Changed 19 months ago by fbissey

I have 2.8.6 as the latest python2 supported version in sage-on-gentoo.

comment:3 follow-up: Changed 19 months ago by slelievre

  • Dependencies set to #28000
  • Keywords upgrade rpy2 added
  • Milestone changed from sage-duplicate/invalid/wontfix to sage-wishlist
  • Summary changed from upgrade rpy2 to 3.1.0 to Upgrade: rpy2 3.x

We can either make this ticket "Upgrade to rpy2 3.x" and make it depend on the removal of py2 support (#28000), or make the ticket "Upgrade to rpy2 2.8.6" which is the latest py2-compatible (2.9 and following are not).

comment:4 in reply to: ↑ 3 Changed 19 months ago by charpent

Replying to slelievre:

We can either make this ticket "Upgrade to rpy2 3.x" and make it depend on the removal of py2 support (#28000), or make the ticket "Upgrade to rpy2 2.8.6" which is the latest py2-compatible (2.9 and following are not).

So the question is: when #28000 will be applied ?

Subidiary question : shouldn't this be a dependency of #28000 ?

comment:5 Changed 19 months ago by charpent

  • Cc charpent added

I am of two minds about whether waiting for #28000:

  • ISTR that 2.8.6 is the last version supporting Python 2. However, Pipy mentions releases version 2.9.0 to 2.9.6b0, the latter being marked as a pre-release for the 3.0.0 bersion released the day after 2.9.6b0 release...
  • What is the increment in functionality that upgrading 2.8.2 --> 2.8.6 gives us ?
  • How expensive (in terms of workload) it is ?

In other words, given our limited resources, isn't it better to wait for a Python-3 based Sagemath and go directly to rpy2 3.1 ?

comment:6 Changed 17 months ago by gh-timokau

  • Cc gh-timokau arojas added
Last edited 17 months ago by gh-timokau (previous) (diff)

comment:7 Changed 15 months ago by arojas

My patch is now up for review at https://trac.sagemath.org/ticket/28988, modified to keep 2.x compatibility so it can be merged independently of the rpy update.

comment:8 Changed 9 months ago by mkoeppe

  • Milestone changed from sage-wishlist to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

dup of #29441, please close

comment:9 Changed 9 months ago by mkoeppe

  • Cc chapoton added

comment:10 Changed 8 months ago by slelievre

  • Component changed from build to packages: standard
  • Reviewers set to Samuel Lelièvre
  • Status changed from needs_review to positive_review

Done at #29441.

comment:11 Changed 8 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.