Changes between Initial Version and Version 2 of Ticket #28463


Ignore:
Timestamp:
09/10/19 22:53:28 (3 years ago)
Author:
gh-kliem
Comment:

I added a suggested fix.

I changed neighbors to only include facets/inequalities. There is no meaning in checking anything else anyway, is there?

Additionally I changed a few things, which I noticed about stacked.

As neighbors did not work for polyhedra with equalities and is not altered for those with without, I don't think a deprecation error is needed.


New commits:

5095c2efix neighbors of Hrepresentatives
8853122small changes to stacking

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28463

    • Property Status changed from new to needs_review
    • Property Authors changed from to Jonathan Kliem
    • Property Summary changed from .stack() or .facet_adjacency_matrix() error in Polyhedron to .neighbors() error in polyhedron.representation
    • Property Branch changed from to public/28463
    • Property Keywords representation neighbors added
    • Property Commit changed from to 8853122c90f902a73d8534734563bd6f874a6393
  • Ticket #28463 – Description

    initial v2  
    3333IndexError: matrix index out of range
    3434}}}
     35
     36We fix `neighbors` of `polyhedron.representation` to only specify inequalities/facets.
     37
     38Also, we do some minor changes to `stack`.