Changes between Version 2 and Version 14 of Ticket #28463


Ignore:
Timestamp:
09/13/19 19:59:14 (3 years ago)
Author:
gh-kliem
Comment:

New commits:

01c5c19improved docstring

New commits:

01c5c19improved docstring

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28463

    • Property Reviewers changed from to Jean-Philippe Labbé
    • Property Commit changed from 8853122c90f902a73d8534734563bd6f874a6393 to 01c5c190ff7ae068fd201c479df6ba8d5a0b3110
  • Ticket #28463 – Description

    v2 v14  
    3434}}}
    3535
    36 We fix `neighbors` of `polyhedron.representation` to only specify inequalities/facets.
     36We fix `neighbors` of `polyhedron.representation` to only specify inequalities/facets. In case of a non-full-dimensional polyhedron, the method had an index shift and did not return anything valuable (if not an error). The method appears to be used only in `stack`, so we do not set a deprecation warning (even so the method is now returning an error for equalities).
    3737
    38 Also, we do some minor changes to `stack`.
     38Also, we do some minor changes to `stack`:
     39- fix a bug: the stacked vertex needs to be in the relative interior of the `locus_polyhedron` (not just interior),
     40- errors for non-proper faces,
     41- remove a redundant test (all vertices of a polyhedron satisfy all of its inequalities/equalites).