Opened 3 years ago
Closed 3 years ago
#28459 closed enhancement (fixed)
spkgconfigure.m4 for glpk
Reported by:  dimpase  Owned by:  

Priority:  major  Milestone:  sage9.0 
Component:  build: configure  Keywords:  spkgconfigure 
Cc:  embray, fbissey, isuruf, arojas, mkoeppe  Merged in:  
Authors:  Dima Pasechnik  Reviewers:  Isuru Fernando 
Report Upstream:  N/A  Work issues:  
Branch:  e6bb511 (Commits, GitHub, GitLab)  Commit:  e6bb511fd244c9ed716292cee349c2adbf597da4 
Dependencies:  #24824  Stopgaps: 
Description (last modified by )
the external install should have glpsol
and libglpk
On debian they are in glpkutils
and libglpkdev
packages.
4ti2
needs to know its prefix (or probably just withglpk
should be there).
Anyhow, we introduce a new env. var. SAGE_GLPK_PREFIX
which is ''
for system's glpk
and SAGE_LOCAL
otherwise.
cvxopt
for its glpk
extension needs to know the (nonstandard) include directory and
library directory of glpk
, so they can be made blank
for the stanard locations  but as in particular libPython comes from SAGE_LOCAL
, this should be left unchanged for the time being.
Sage's glpk
needs a specific patch which is not upstreamed, so we need to work this out, too.
Change History (16)
comment:1 Changed 3 years ago by
 Description modified (diff)
comment:2 Changed 3 years ago by
 Commit changed from 2f10a522044356a0946ac35bc309cf21dd65bb9f to 08d353c76cef0d6f33913aee311d1784d8778ed5
comment:3 Changed 3 years ago by
 Commit changed from 08d353c76cef0d6f33913aee311d1784d8778ed5 to e6bb511fd244c9ed716292cee349c2adbf597da4
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
e6bb511  spkgconfigure.m4 for glpk

comment:4 Changed 3 years ago by
 Cc embray fbissey isuruf arojas added
 Description modified (diff)
 Keywords spkgconfigure added
 Status changed from new to needs_review
Does anyone know a system that does not carry Sage's GLPK patch? (I guess Debian does, right?)
comment:5 followup: ↓ 6 Changed 3 years ago by
Debian 10 carries GLPK 4.65, and 4 tests in src/sage/numerical/backends/glpk_backend.pyx
fail due to minor formating differences, e.g. extra blank line...
comment:6 in reply to: ↑ 5 Changed 3 years ago by
Replying to dimpase:
Debian 10 carries GLPK 4.65, and 4 tests in
src/sage/numerical/backends/glpk_backend.pyx
fail due to minor formating differences, e.g. extra blank line...
Same for Arch. Given that 4.65 is 1.5 years old and most distros are shipping it already, IMO it would be best to update sage's glpk first before dealing with this.
comment:7 Changed 3 years ago by
 Dependencies set to #24824
I've put the update to glpk 4.65 on #24824
comment:8 Changed 3 years ago by
 Cc mkoeppe added
On #24824 I've also adjusted tests so ithat only one test fails with Debian's glpk 4.65, which does not apply one of Sage's patches, glpk/patches/error_recovery.patch
.
(And in fact the still failing test can be switched off or changed into something that does not need the patch in question).
comment:9 Changed 3 years ago by
here I keep minimal requirement version of glpk to be 4.63. This results in few failing tests, all just from glpk 4.63 being too chatty in logging, nothing serious.
comment:10 Changed 3 years ago by
Looks good to me in principle though I haven't tested yet. I'll try to test later this week. Thanks!
comment:11 Changed 3 years ago by
ping?
comment:12 Changed 3 years ago by
 Milestone changed from sage8.9 to sage9.0
comment:13 Changed 3 years ago by
 Status changed from needs_review to positive_review
Works for me in conda
comment:14 Changed 3 years ago by
 Status changed from positive_review to needs_work
Reviewer name...
comment:15 Changed 3 years ago by
 Reviewers set to Isuru Fernando
 Status changed from needs_work to positive_review
comment:16 Changed 3 years ago by
 Branch changed from u/dimpase/packages/glpkconfig to e6bb511fd244c9ed716292cee349c2adbf597da4
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
spkgconfigure.m4 for glpk