Opened 3 years ago

Closed 3 years ago

#28458 closed enhancement (fixed)

Housekeeping for hypergeometric motives

Reported by: kedlaya Owned by:
Priority: minor Milestone: sage-8.9
Component: modular forms Keywords: hypergeometric motives
Cc: Merged in:
Authors: Kiran Kedlaya Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: dfb2f29 (Commits, GitHub, GitLab) Commit: dfb2f292d37f26c521a22c07ce40070992ec85fb
Dependencies: Stopgaps:

Status badges


This ticket includes some housekeeping for sage.modular.hypergeometric_motive.HypergeometricData.

  • Reordered methods into clearer categories (internals, parameters/invariants, operations, L-functions).
  • Added some utility methods: alpha, beta, hodge_polygon_function, hodge_polygon_vertices.
  • We now cache some of the parameters at creation time, to reduce overhead when computing many Euler factors.
  • Some simple but effective optimizations to padic_H_value. Most significantly, we eliminate redundant calls to padic_gauss_sum.

In addition, we make some tweaks to sage.rings.padics.padic_generic_element.gamma, including optimizing the working precision.

Change History (5)

comment:1 Changed 3 years ago by kedlaya

  • Branch set to u/kedlaya/housekeeping_for_hypergeometric_motives

comment:2 Changed 3 years ago by chapoton

  • Commit set to e1cf61322aeaab6369358e55cc3c165dba1de47d

ready for review ?

New commits:

dbe037cHousekeeping for HGMs
e1cf613Clean up p-adic gamma, docstrings

comment:3 Changed 3 years ago by kedlaya

  • Authors set to Kiran Kedlaya
  • Status changed from new to needs_review

Patchbot seems to think so...

comment:4 Changed 3 years ago by chapoton

  • Branch changed from u/kedlaya/housekeeping_for_hypergeometric_motives to public/ticket/28458
  • Commit changed from e1cf61322aeaab6369358e55cc3c165dba1de47d to dfb2f292d37f26c521a22c07ce40070992ec85fb
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok. I made a few cosmetic changes (pep8 formatting).

I am setting to positive.

New commits:

dfb2f29trac 28458 cosmetic (pep8) changes

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/ticket/28458 to dfb2f292d37f26c521a22c07ce40070992ec85fb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.