#28457 closed enhancement (fixed)

Build binder compatible docker images from Trac

Reported by: saraedum Owned by:
Priority: major Milestone: sage-9.2
Component: docker Keywords: sd109
Cc: slelievre, nthiery, embray, roed, vdelecroix Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: e353fd5 (Commits, GitHub, GitLab) Commit: e353fd549e71e3d97656942373ab1e8e3d770898
Dependencies: #28041 Stopgaps:

Status badges

Description (last modified by saraedum)

By tagging all our images with the commit SHA in GitLab registry.

You cannot sanely create a binder that points to a moving target such as a branch. Therefore, all images need to have unique tags.

With the changes merged, links like this should work for all branches on trac:

https://gitlab-hooks-flau3jeaza-ew.a.run.app/status/trac/branch/u%2Fsaraedum%2F28457

Change History (11)

comment:1 Changed 22 months ago by saraedum

  • Branch set to u/saraedum/28457

comment:2 Changed 22 months ago by git

  • Commit set to 3de1e646bee79f8646f935dc00d2e739de5a0d5b

Branch pushed to git repo; I updated commit sha1. New commits:

3de1e64Merge remote-tracking branch 'trac/develop' into 28457

comment:3 Changed 22 months ago by git

  • Commit changed from 3de1e646bee79f8646f935dc00d2e739de5a0d5b to e353fd549e71e3d97656942373ab1e8e3d770898

Branch pushed to git repo; I updated commit sha1. New commits:

e353fd5fix typo

comment:4 Changed 21 months ago by saraedum

  • Cc vdelecroix added
  • Status changed from new to needs_review

This can be reviewed once #28041 has been merged.

comment:5 Changed 21 months ago by saraedum

  • Description modified (diff)

comment:6 Changed 19 months ago by slelievre

Note #28041 was merged in 9.0.beta0, so this can now be reviewed.

comment:7 Changed 18 months ago by embray

  • Milestone changed from sage-8.9 to sage-9.1

Ticket retargeted after milestone closed

comment:8 Changed 14 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

comment:9 Changed 13 months ago by mkoeppe

  • Keywords sd109 added

comment:10 Changed 13 months ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

This looks reasonable to me.

comment:11 Changed 13 months ago by vbraun

  • Branch changed from u/saraedum/28457 to e353fd549e71e3d97656942373ab1e8e3d770898
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.