Opened 2 years ago

Closed 2 years ago

#28446 closed defect (fixed)

pdf doc build is broken by #28271

Reported by: fbissey Owned by:
Priority: blocker Milestone: sage-8.9
Component: documentation Keywords:
Cc: strogdon Merged in:
Authors: François Bissey Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: d5862a9 (Commits, GitHub, GitLab) Commit: d5862a91c732c95ac1366273c66cd8d7b445cf97
Dependencies: Stopgaps:

Status badges

Description

#28271 introduced a unicode minus sign in the documentation. It causes the pdf building of the documentation to break

! Package inputenc Error: Unicode character − (U+2212)
(inputenc)                not set up for use with LaTeX.

See the inputenc package documentation for explanation.
Type  H <return>  for immediate help.
 ...

l.65295 ... that for every \(i \in \{1, ..., n −
                                                   1\}\) the
?
! Emergency stop.
 ...

l.65295 ... that for every \(i \in \{1, ..., n −
                                                   1\}\) the
You may provide a definition with
\DeclareUnicodeCharacter

The offending minus sign is on line 1284 of the file src/sage/graphs/traversals.pyx.

Change History (8)

comment:1 Changed 2 years ago by fbissey

  • Authors set to François Bissey
  • Branch set to u/fbissey/unicode_minus
  • Commit set to d5862a91c732c95ac1366273c66cd8d7b445cf97
  • Status changed from new to needs_review

New commits:

d5862a9replace unicode minus sign with a normal "-"

comment:2 follow-up: Changed 2 years ago by dcoudert

Sorry for that, bad copy/paste.

Do we have a "quick" way to check that pdf building goes well ?

comment:3 in reply to: ↑ 2 Changed 2 years ago by fbissey

Replying to dcoudert:

Sorry for that, bad copy/paste.

No worries. Those are hard to spot until they cause troubles. I intend to use that little commit in pedagogical ways. Can you spot the difference?

Do we have a "quick" way to check that pdf building goes well ?

No. As far as I know you just have to build the whole thing. On the other hand I checked that it was the only such character in the branch.

comment:4 follow-up: Changed 2 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

The difference between the 2 symbols is hard to see, but with some effort I can see it...

LGTM.

comment:5 in reply to: ↑ 4 Changed 2 years ago by fbissey

Replying to dcoudert:

The difference between the 2 symbols is hard to see, but with some effort I can see it...

This is difficult to ascertain. First you need suppress the colouring of the commit to remove optical illusion and color bleeding. If you are short sighted the default choice of green and red has a definite impact on your perception of size. For other eye conditions there will also be some effect but possibly less pronounced.

LGTM.

Thanks.

comment:6 Changed 2 years ago by strogdon

I think this needs to be in 8.9 or else the pdf docs will not build. Would making it a blocker help that? Or do we just cross our fingers?

comment:7 Changed 2 years ago by fbissey

  • Priority changed from major to blocker

It is a very minor change. I put it as a blocker.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/fbissey/unicode_minus to d5862a91c732c95ac1366273c66cd8d7b445cf97
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.