Changes between Version 1 and Version 2 of Ticket #28444, comment 63


Ignore:
Timestamp:
09/06/19 13:37:52 (2 years ago)
Author:
SimonKing
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28444, comment 63

    v1 v2  
    1 I replaced the old second commit by a commit that is less invasive: It changes the conversion functions so that they return the input unaltered if its type fits, it uses the conversion functions in `matrix_gfpn_dense` for unpickling (I think that's cleaner than doing a type check there), and I also use it in `lookup_global`, because if we want to support `encoding='bytes'` at all, we have to make lookup work with that option.
     1I replaced the old second commit by a commit that is less invasive: It changes the conversion functions so that they return the input unaltered if its type fits, it uses the conversion functions in `matrix_gfpn_dense` for unpickling (I think that's cleaner than doing a type check there), and it also uses them in `lookup_global`, because if we want to support `encoding='bytes'` at all, we have to make lookup work with that option.
    22
    33So, from my perspective, the code itself is ready to be used. But we should add some tests. Ideas how they could look? I could imagine to use a string that was created by `dumps` in Python-2 and demonstrate that the string can be interpreted by `loads`, regardless whether it is Py-2 or Py-3.