Opened 3 years ago

Closed 3 years ago

#28430 closed enhancement (fixed)

Polyhedron: Preserve backend for barycentric subdivision

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-8.9
Component: geometry Keywords: polyhedron, polytopes, barycentric subdivision, backend
Cc: jipilab, vdelecroix Merged in:
Authors: Jonathan Kliem Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: ae7d717 (Commits, GitHub, GitLab) Commit: ae7d717da5b7375b07f71abfe1efc04769259239
Dependencies: Stopgaps:

Status badges


This is a follow up of #27926. barycentric_subdivision was forgotten there.

Currently we have

sage: polytopes.simplex(backend='field').barycentric_subdivision().backend()

The backend should not be changed with this construction, so the desired output in this case is 'field'.

Change History (5)

comment:1 Changed 3 years ago by gh-kliem

  • Branch set to public/28430
  • Commit set to ae7d717da5b7375b07f71abfe1efc04769259239
  • Status changed from new to needs_review

New commits:

ae7d717preserve backend for barycentric subdivision

comment:2 Changed 3 years ago by jipilab

Wow! Fast at fixing it! Great!

comment:3 Changed 3 years ago by tscrim

Is that a positive review JP?

comment:4 Changed 3 years ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_review to positive_review

At the moment that I wrote the lines, I was thinking about a potential improvement of the method, but it turns out it is a bit more involved, so I'd say yes, it is a positive review.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/28430 to ae7d717da5b7375b07f71abfe1efc04769259239
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.