Opened 3 years ago

Closed 3 years ago

#28417 closed enhancement (fixed)

removed deprecated stuff in integer_mod

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.9
Component: basic arithmetic Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ed57eb7 (Commits, GitHub, GitLab) Commit: ed57eb742ca4dcccdb1ae66a8affffb29fb740f7
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

after #15804

also moving some import from inside methods to the top of file

(partly suggested by #23746)

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28417
  • Commit set to 7f922c1fc298e3d5560cf1c509e405f3dc618644
  • Status changed from new to needs_review

New commits:

7f922c1refresh the prompt in the source installation guide

comment:2 Changed 3 years ago by git

  • Commit changed from 7f922c1fc298e3d5560cf1c509e405f3dc618644 to 3f0161c7a46a783b6faaa77a5f0a66ea7e64f624

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3f0161ctrac 28417 remove deprecated import in integer_mod and move some imports there

comment:3 Changed 3 years ago by git

  • Commit changed from 3f0161c7a46a783b6faaa77a5f0a66ea7e64f624 to ed57eb742ca4dcccdb1ae66a8affffb29fb740f7

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ed57eb7trac 28417 just remove deprecated stuff in integer_mod

comment:4 Changed 3 years ago by chapoton

ok, I have undone the change in imports, that were not working because of a cyclic import..

comment:5 Changed 3 years ago by chapoton

  • Cc tscrim jmantysalo added

green bot, please review (very easy one)

comment:6 Changed 3 years ago by chapoton

  • Description modified (diff)

comment:7 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28417 to ed57eb742ca4dcccdb1ae66a8affffb29fb740f7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.