Opened 3 years ago

Closed 3 years ago

#28416 closed enhancement (fixed)

Add subjoinsemilattice

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-9.0
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 18cd74e (Commits, GitHub, GitLab) Commit: 18cd74e53074d4b73f675fa741b48cb867e8464c
Dependencies: Stopgaps:

Status badges

Description

When #27818 is closed add the dual of it.

Change History (11)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/add_subjoinsemilattice

comment:2 Changed 3 years ago by jmantysalo

  • Commit set to 8a955ba9fbaf330e686e80a73a866855617844d5
  • Status changed from new to needs_review

Trivial dual function.


New commits:

8a955baAdd dual for sub-meetsemilattice.

comment:3 follow-up: Changed 3 years ago by chapoton

typo in "gens_remaning" comment

comment:4 in reply to: ↑ 3 Changed 3 years ago by jmantysalo

Replying to chapoton:

typo in "gens_remaning" comment

Sorry, I didn't get this. Where?

comment:5 follow-up: Changed 3 years ago by chapoton

in the comments (also in the previous similar ticket) remaning >>> remaining

comment:6 Changed 3 years ago by git

  • Commit changed from 8a955ba9fbaf330e686e80a73a866855617844d5 to 18cd74e53074d4b73f675fa741b48cb867e8464c

Branch pushed to git repo; I updated commit sha1. New commits:

18cd74eA typo

comment:7 in reply to: ↑ 5 Changed 3 years ago by jmantysalo

Replying to chapoton:

in the comments (also in the previous similar ticket) remaning >>> remaining

Ah, I just skipped it as "code"... Thanks.

comment:8 follow-up: Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok.

I would have called that "meet_closure" and "join_closure".

comment:9 in reply to: ↑ 8 Changed 3 years ago by jmantysalo

Replying to chapoton:

I would have called that "meet_closure" and "join_closure".

True. Would have been better.

comment:10 Changed 3 years ago by chapoton

  • Milestone changed from sage-8.9 to sage-9.0

moving milestone to 9.0 (after release of 8.9)

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/add_subjoinsemilattice to 18cd74e53074d4b73f675fa741b48cb867e8464c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.