Opened 3 years ago
Closed 3 years ago
#28407 closed defect (fixed)
py3: fix quantum_group_gap and graph_latex
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.9 |
Component: | python3 | Keywords: | |
Cc: | dcoudert, tscrim, dimpase | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | 399bdc6 (Commits, GitHub, GitLab) | Commit: | 399bdc6fb542696084857221b0787929cc562307 |
Dependencies: | Stopgaps: |
Description
after the wrong fix made in #28312
Change History (7)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/28407
- Commit set to 399bdc6fb542696084857221b0787929cc562307
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
- Reviewers set to David Coudert
- Status changed from needs_review to positive_review
Passes doctests with py2 and py3 on OSX.
comment:3 Changed 3 years ago by
Just to be sure, did you test with the optional "gap_packages" installed ?
comment:4 Changed 3 years ago by
- Status changed from positive_review to needs_work
oups, I have it for py3 but not for py2. I come back as soon as it is installed.
comment:5 Changed 3 years ago by
- Status changed from needs_work to needs_review
comment:6 Changed 3 years ago by
- Status changed from needs_review to positive_review
LGTM
With py2:
Using --optional=bliss,build,csdp,dochtml,gap_packages,gfortran,igraph,libsemigroups,mpir,plantri,python2,python_igraph,sage,tdlib Doctesting 1 file using 4 threads. sage -t --long src/sage/algebras/quantum_groups/quantum_group_gap.py [529 tests, 13.92 s] ---------------------------------------------------------------------- All tests passed! ---------------------------------------------------------------------- sage -t --long src/sage/graphs/graph_latex.py [194 tests, 0.63 s] ---------------------------------------------------------------------- All tests passed! ----------------------------------------------------------------------
comment:7 Changed 3 years ago by
- Branch changed from u/chapoton/28407 to 399bdc6fb542696084857221b0787929cc562307
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
This needs to be tested with python2. I no longer have any python2-sage anywhere.
New commits:
py3: fix quantum_group_gap and graph_latex