Opened 3 years ago
Closed 3 years ago
#28405 closed defect (fixed)
correct the test for galpol package in pari's spkg-configure.m4
Reported by: | dimpase | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-8.9 |
Component: | build: configure | Keywords: | |
Cc: | embray, fbissey, isuruf, vdelecroix | Merged in: | |
Authors: | Dima Pasechnik | Reviewers: | Isuru Fernando |
Report Upstream: | N/A | Work issues: | |
Branch: | 7d01e58 (Commits, GitHub, GitLab) | Commit: | 7d01e5800afe1741779fd9cb835742ac64136b31 |
Dependencies: | Stopgaps: |
Description (last modified by )
the test written there
if test "x$gp_galp_check = xC3\ \:\ C4"; then
always evaluates to true.
It is meant to check whether gp_galp_check
(which may be empty) equals the string
"C3 : C4"
Change History (6)
comment:1 Changed 3 years ago by
- Description modified (diff)
comment:2 Changed 3 years ago by
Shouldn't it be
"x$gp_galp_check" = "xC3 : C4"
?
comment:3 Changed 3 years ago by
- Branch set to u/dimpase/packages/paritestfix
- Commit set to 7d01e5800afe1741779fd9cb835742ac64136b31
- Status changed from new to needs_review
I've moved the test into the call to gp, now it works.
New commits:
7d01e58 | let gp do the check and return 0/1
|
comment:4 Changed 3 years ago by
- Cc vdelecroix added
comment:5 Changed 3 years ago by
- Reviewers set to Isuru Fernando
- Status changed from needs_review to positive_review
I can confirm the issue and that this ticket correctly detects that galpol is not installed.
comment:6 Changed 3 years ago by
- Branch changed from u/dimpase/packages/paritestfix to 7d01e5800afe1741779fd9cb835742ac64136b31
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
my patchy knowledge of autoconf/m4/shell syntax does not suffice, please help...