#28401 closed defect (fixed)

pass correct --with-flint to eclib's configure

Reported by: dimpase Owned by:
Priority: critical Milestone: sage-8.9
Component: build: configure Keywords:
Cc: embray, fbissey, isuruf Merged in:
Authors: Dima Pasechnik Reviewers: Vincent Delecroix
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: 1db8f2a (Commits, GitHub, GitLab) Commit: 1db8f2acebd48454b234f5a8b100ed06e45a743e
Dependencies: Stopgaps:

Status badges

Description

It's reported in [this thread on sage-devel https://groups.google.com/d/msg/sage-devel/OJJFRAgvtqk/JZMEdA81EAAJ] that "wrong" libraries in /lib may shadow the "right" one in SAGE_LOCAL/lib for eclib (this happens with libpari)

It appears to be due to --with-flint="" being passed instead of --with-flint in spkg-install of eclib, adding a spurrous -L/lib to the ld search path for building eclib

Change History (8)

comment:1 Changed 18 months ago by dimpase

  • Report Upstream changed from N/A to None of the above - read trac for reasoning.

I've opened https://github.com/JohnCremona/eclib/pull/57 to make eclib more consistent, but will not rely on this accepted to fix this bug.

comment:2 follow-up: Changed 18 months ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/packages/eclibfix
  • Cc embray fbissey isuruf added
  • Commit set to 8d5ef3c97cb1643ecc4276e07cbef16b198a9f84
  • Status changed from new to needs_review

this could be removed once a new eclib version with https://github.com/JohnCremona/eclib/pull/57 is in Sage.


New commits:

8d5ef3cpass correct --with-flint... to eclib

comment:3 in reply to: ↑ 2 ; follow-up: Changed 18 months ago by vdelecroix

Replying to dimpase:

this could be removed once a new eclib version with https://github.com/JohnCremona/eclib/pull/57 is in Sage.

Could you add this comment in the install script?

comment:4 Changed 18 months ago by git

  • Commit changed from 8d5ef3c97cb1643ecc4276e07cbef16b198a9f84 to 1db8f2acebd48454b234f5a8b100ed06e45a743e

Branch pushed to git repo; I updated commit sha1. New commits:

1db8f2aadded comment into spkg-install

comment:5 in reply to: ↑ 3 Changed 18 months ago by dimpase

Replying to vdelecroix:

Replying to dimpase:

this could be removed once a new eclib version with https://github.com/JohnCremona/eclib/pull/57 is in Sage.

Could you add this comment in the install script?

done

comment:6 Changed 18 months ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

comment:7 Changed 18 months ago by dimpase

Thanks Vincent, could you please also review #28405 ? It fixes another bug discovered while I looked at your logs you posted w.r.t. the problem fixed here.

comment:8 Changed 18 months ago by vbraun

  • Branch changed from u/dimpase/packages/eclibfix to 1db8f2acebd48454b234f5a8b100ed06e45a743e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.