Opened 3 years ago

Closed 3 years ago

#28399 closed enhancement (fixed)

remove deprecated things in integer.pyx

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.9
Component: refactoring Keywords:
Cc: tscrim, jmantysalo, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c537c68 (Commits, GitHub, GitLab) Commit: c537c68af2ad620cf76c26b001d44cb51b72ec68
Dependencies: Stopgaps:

Status badges

Description

after #24260 and #17852

Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28399
  • Commit set to 9debf174ab8d491a3d971d90be45302e3212e3bd
  • Status changed from new to needs_review

New commits:

aa8a2b2remove deprecated stuff from 24260
9debf17remove deprecated stuff from 17852

comment:2 Changed 3 years ago by chapoton

one failure in src/sage/rings/asymptotic/term_monoid.py

comment:3 Changed 3 years ago by git

  • Commit changed from 9debf174ab8d491a3d971d90be45302e3212e3bd to c537c68af2ad620cf76c26b001d44cb51b72ec68

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4bcd173remove deprecated stuff from 24260
c537c68remove deprecated stuff from 17852

comment:4 Changed 3 years ago by chapoton

failure is fixed

comment:5 Changed 3 years ago by chapoton

  • Cc tscrim jmantysalo vklein added

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28399 to c537c68af2ad620cf76c26b001d44cb51b72ec68
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.