Opened 3 years ago

Closed 3 years ago

#28393 closed enhancement (fixed)

add self-tests for polymake

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-8.9
Component: packages: experimental Keywords: sdl
Cc: mkoeppe Merged in:
Authors: Thierry Monteil Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 7272543 (Commits, GitHub, GitLab) Commit: 7272543d60e5c124ea2f5cb67f2a0cd1441034b9
Dependencies: Stopgaps:

Status badges

Description

polymake Makefile has a test target, so we should have a spkg-check file to enable self-tests.

Change History (5)

comment:1 Changed 3 years ago by tmonteil

  • Branch set to u/tmonteil/add_self_tests_for_polymake

comment:2 Changed 3 years ago by tmonteil

  • Cc mkoeppe added
  • Commit set to 7272543d60e5c124ea2f5cb67f2a0cd1441034b9
  • Status changed from new to needs_review

New commits:

​7272543#28393 add self-tests for polymake

comment:3 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:4 Changed 3 years ago by tmonteil

  • Keywords sdl added

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/tmonteil/add_self_tests_for_polymake to 7272543d60e5c124ea2f5cb67f2a0cd1441034b9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.