Opened 3 years ago

Last modified 3 months ago

#28381 new enhancement

Readabiltiy fixes for sage-coding-theory goppa_code.py

Reported by: J Owned by: J
Priority: trivial Milestone: sage-9.8
Component: coding theory Keywords:
Cc: gh-emes4 Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: u/gh-927589452/coding_theory_suggestions (Commits, GitHub, GitLab) Commit: c9fb9f0c30f9eb25e2a563d42a30d062dd197dee
Dependencies: Stopgaps:

Status badges

Description (last modified by J)

I will use this ticket to collect a few improvements I wanted to suggest for the coding theory projects goppa implementation

Change History (21)

comment:1 Changed 3 years ago by J

Owner: set to J

comment:2 Changed 3 years ago by J

Branch: u/gh-927589452/coding_theory_suggestions

comment:3 Changed 3 years ago by Dima Pasechnik

it seems that you don't have the correct branch pushed.

comment:4 Changed 3 years ago by git

Commit: 9953e4e572a52918fa0c84991c48faef0b9ec3bf

Branch pushed to git repo; I updated commit sha1. New commits:

9953e4eMerge all rows in one loop

comment:5 in reply to:  3 Changed 3 years ago by J

Replying to dimpase:

it seems that you don't have the correct branch pushed.

Not exactly I hadn't pushed it yet to the trac server

comment:6 in reply to:  4 Changed 3 years ago by J

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

9953e4eMerge all rows in one loop

This is just a cleaner / better readable version of the parity check generation

comment:7 Changed 3 years ago by Dima Pasechnik

This needs to be done over current beta (beta 7), not beta 3. As you see, your branch does not merge cleanly over the current beta (it is shown in red).

comment:8 in reply to:  7 Changed 3 years ago by J

Replying to dimpase:

This needs to be done over current beta (beta 7), not beta 3. As you see, your branch does not merge cleanly over the current beta (it is shown in red).

will do

comment:9 Changed 3 years ago by git

Commit: 9953e4e572a52918fa0c84991c48faef0b9ec3bfc9fb9f0c30f9eb25e2a563d42a30d062dd197dee

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c9fb9f0Merge all rows in one loop

comment:10 in reply to:  7 Changed 3 years ago by J

Replying to dimpase:

This needs to be done over current beta (beta 7), not beta 3. As you see, your branch does not merge cleanly over the current beta (it is shown in red).

fixed it

(thanks to https://stackoverflow.com/questions/3491270/git-merge-apply-changes-to-code-that-moved-to-a-different-file )

comment:11 Changed 3 years ago by gh-emes4

Cc: gh-emes4 added

comment:12 Changed 3 years ago by Erik Bray

Please update the ticket title to better summarize what is being improved

comment:13 Changed 3 years ago by J

Description: modified (diff)
Summary: minor improvementsReadabiltiy fixes for sage-coding-theory goppa_code.py

updated title

comment:14 Changed 3 years ago by Erik Bray

Milestone: sage-8.9sage-9.1

Ticket retargeted after milestone closed

comment:15 Changed 3 years ago by Matthias Köppe

Milestone: sage-9.1sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:16 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:17 Changed 22 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:18 Changed 17 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

comment:19 Changed 12 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:20 Changed 8 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:21 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8
Note: See TracTickets for help on using tickets.