Opened 3 years ago

Closed 3 years ago

#28380 closed defect (fixed)

bump up the version of givaro in spkg-configure.m4

Reported by: dimpase Owned by:
Priority: critical Milestone: sage-8.9
Component: build: configure Keywords: spkg-configure
Cc: embray, fbissey, isuruf Merged in:
Authors: Dima Pasechnik Reviewers: Isuru Fernando
Report Upstream: N/A Work issues:
Branch: 2a2fa57 (Commits, GitHub, GitLab) Commit: 2a2fa57e9082596c3eade7a3f864fa2ee35eb7f2
Dependencies: #28342 Stopgaps:

Status badges

Description

something went a bit wrong with testing of #28342, and in fact #26932 breaks the use of givaro 4.0.4. One needs to apply

  • build/pkgs/givaro/spkg-configure.m4

    a b  
    11SAGE_SPKG_CONFIGURE([givaro], [
    2     m4_pushdef([SAGE_GIVARO_MINVER],["40004"])
     2    m4_pushdef([SAGE_GIVARO_MINVER],["40101"])
    33    SAGE_SPKG_DEPCHECK([gmp mpir], [
    44        AC_PATH_PROG([GIVAROCONFIG], [givaro-config])
    55        AS_IF([test x$GIVAROCONFIG = x], [

Change History (6)

comment:1 Changed 3 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/packages/givaro411
  • Commit set to 5e4712548d128a997e72ff31a0a00f8257a6bd81
  • Component changed from PLEASE CHANGE to build: configure
  • Dependencies set to #28342
  • Keywords spkg-configure added
  • Status changed from new to needs_review

New commits:

f0bf6deSAGE_SPKG_DEPCHECK, spkg-configure for m4ri(e), givaro
7eca641remove spurious '$'
50a3256update lists of packages which can be useful for installation
2b348c5remove unneeded parameter, use SPKG_NAME instead
313ddc3mention lcalc system packages (prepare for #28224)
5e47125bump up givaro version due to #26932

comment:2 Changed 3 years ago by isuruf

  • Reviewers set to Isuru Fernando
  • Status changed from needs_review to positive_review

comment:3 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:4 Changed 3 years ago by git

  • Commit changed from 5e4712548d128a997e72ff31a0a00f8257a6bd81 to 2a2fa57e9082596c3eade7a3f864fa2ee35eb7f2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2a2fa57bump up givaro version due to #26932

comment:5 Changed 3 years ago by dimpase

  • Status changed from needs_work to positive_review

rebased

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/packages/givaro411 to 2a2fa57e9082596c3eade7a3f864fa2ee35eb7f2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.