Opened 2 years ago

Closed 2 years ago

#28366 closed defect (fixed)

Lattice precision timing test fails on Windows 7 due to low-ish clock resolution

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.9
Component: padics Keywords: time, cygwin, Windows7
Cc: slelievre Merged in:
Authors: Erik Bray Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: 8a3d448 (Commits, GitHub, GitLab) Commit: 8a3d448c164bf2f4ae49ed2915b05d34c478f422
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

In src/sage/ring/padics/lattice_precision.py, use if status rather than if total_time > 0.

They are supposed to be equivalent, but the clock resolution in Cygwin on Windows 7 is so low that total_time can be zero even when status evaluates to True as a boolean.

Change History (3)

comment:1 Changed 2 years ago by embray

  • Authors set to Erik Bray
  • Branch set to public/ticket-28366
  • Commit set to 8a3d448c164bf2f4ae49ed2915b05d34c478f422
  • Status changed from new to needs_review

New commits:

8a3d448Trac #28366: Append history lines when status is non-empty, ignoring actual total time (which may be zero when the clock is low resolution)

comment:2 Changed 2 years ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
  • Keywords time cygwin Windows7 added
  • Reviewers set to Samuel Lelièvre
  • Status changed from needs_review to positive_review

comment:3 Changed 2 years ago by vbraun

  • Branch changed from public/ticket-28366 to 8a3d448c164bf2f4ae49ed2915b05d34c478f422
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.