#28333 closed enhancement (fixed)

spkg-configure.m4 for eclib

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.9
Component: build: configure Keywords:
Cc: embray, fbissey, isuruf Merged in:
Authors: Dima Pasechnik Reviewers: Isuru Fernando
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: 699f220 (Commits) Commit: 699f220c8849846e96de12d400eede2d81ff27b0
Dependencies: #28242 Stopgaps:

Description (last modified by dimpase)

the main issue here is how to check that the version installed on the system is good enough.

We check for a header that only appeared in 2018, that's all we could find atm.

Change History (18)

comment:1 Changed 18 months ago by dimpase

  • Dependencies set to #28242
  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

comment:2 Changed 18 months ago by dimpase

while at it, we should fix eclib's spkg-install, which should always have --with-flint, otherwise flint is not linked it (causing worse performance I guess).

comment:3 Changed 18 months ago by dimpase

comment:4 Changed 18 months ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to build/pkgs/eclib/spkg-configure.m4

comment:5 Changed 18 months ago by dimpase

  • Branch changed from build/pkgs/eclib/spkg-configure.m4 to u/dimpase/packages/eclib-config
  • Commit set to 0c8bf98a8aa8c97000d33ae2821cda34b2e6dab4

New commits:

2f45c9espkg-configure for pari
b622942spkg-configure for pari_elldata
2e11aedspkg-configure's for PARI packages
183f47ccheck for PARI packages in PARI's spkg-configure
72f3c20spkg-configure for gp2c
6eac550as pari might become dummy, test with GAP
ac207d5don't export GP_DATA_DIR, remove other, unneeded GP* vars
317f090proper dependency resolution (all tests in PARI spkg-config)
2c26115docbuild workaround for external PARI
0c8bf98spkg-configure for eclib

comment:6 Changed 18 months ago by dimpase

  • Description modified (diff)

comment:7 Changed 18 months ago by git

  • Commit changed from 0c8bf98a8aa8c97000d33ae2821cda34b2e6dab4 to 6745e5df8c92d44f86eb01824f8e63fc5ea05c95

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e53d6a7spkg-configure for eclib
6745e5duse internal or external flint, always

comment:8 Changed 18 months ago by dimpase

The current Debian eclib is too old, one needs to rule it out using something like https://github.com/JohnCremona/eclib/issues/56#issuecomment-519813168


New commits:

e53d6a7spkg-configure for eclib
6745e5duse internal or external flint, always

comment:9 Changed 18 months ago by git

  • Commit changed from 6745e5df8c92d44f86eb01824f8e63fc5ea05c95 to 63ead0764fd518806a6890aedd112bc68526f7d8

Branch pushed to git repo; I updated commit sha1. New commits:

63ead07added test for versions >= v20190226

comment:10 Changed 18 months ago by dimpase

  • Status changed from new to needs_review

comment:11 Changed 18 months ago by dimpase

  • Cc embray fbissey isuruf added

To test this, I checked that eclib from Debian 10 does not get picked up (as it should be). Then I uninstalled the system's eclib and installed the current eclib into /usr/local (with the configure parameters as in spkg-install), and it got picked up just fine.

comment:12 Changed 18 months ago by isuruf

  • Status changed from needs_review to needs_work
configure:12023: /projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 -o conftest -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -I/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/include -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -I/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/include -Wl,-O2 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--disable-new-dtags -Wl,--gc-sections -L/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/lib -Wl,-rpath,/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/lib -lec conftest.cpp -lmpfr -lgmp -lm  -lntl >&5
/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: /tmp/ccEA25VC.o: in function `main':
conftest.cpp:(.text.startup.main+0x11): undefined reference to `show_version()'

Note that -lec comes before conftest.cpp and not after like the other libs.

comment:13 Changed 18 months ago by git

  • Commit changed from 63ead0764fd518806a6890aedd112bc68526f7d8 to c4665b3a2beed3f29512b2932a9773c9032d8756

Branch pushed to git repo; I updated commit sha1. New commits:

c4665b3correct LIBS and LDFLAGS to link correctly

comment:14 Changed 18 months ago by dimpase

  • Status changed from needs_work to needs_review

OK, I've fixed this, it was a really bad bug there, not the least wrong number of parameters used for AC_RUN_IFELSE.

comment:15 Changed 18 months ago by git

  • Commit changed from c4665b3a2beed3f29512b2932a9773c9032d8756 to 699f220c8849846e96de12d400eede2d81ff27b0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dd2b3faredirect gp errors to config.log
23f8448spkg-configure for eclib
af16082use internal or external flint, always
7a8d11eadded test for versions >= v20190226
699f220correct LIBS and LDFLAGS to link correctly

comment:16 Changed 18 months ago by dimpase

rebased over updated #28242

comment:17 Changed 18 months ago by isuruf

  • Reviewers set to Isuru Fernando
  • Status changed from needs_review to positive_review

Works for me in conda

comment:18 Changed 18 months ago by vbraun

  • Branch changed from u/dimpase/packages/eclib-config to 699f220c8849846e96de12d400eede2d81ff27b0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.