Opened 3 years ago

Closed 3 years ago

#28317 closed defect (fixed)

Use -print-prog-name instead of -print-file-name in gcc spkg-configure.m4

Reported by: isuruf Owned by:
Priority: major Milestone: sage-8.9
Component: build: configure Keywords:
Cc: embray, dimpase Merged in:
Authors: Isuru Fernando Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: dec073b (Commits, GitHub, GitLab) Commit: dec073b837d2105b92dcc2b06c9b4c6d65970998
Dependencies: Stopgaps:

Status badges

Description

Here's what I get

~/sage$ echo $CC
/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/x86_64-conda_cos6-linux-gnu-cc

~/sage$ $CC -print-prog-name=ld
/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld

~/sage$ $CC -print-file-name=ld
ld

~/sage$ echo $LD
/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/x86_64-conda_cos6-linux-gnu-ld

Therefore -print-file-name is clearly not what we need. -print-prog-name gives a path with ..s in it.

We need to check that the two files are equivalent using -ef which checks that the files are the same.

Change History (4)

comment:1 Changed 3 years ago by isuruf

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by isuruf

  • Cc dimpase added

comment:3 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

looks good.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/isuruf/gcc-prog to dec073b837d2105b92dcc2b06c9b4c6d65970998
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.