Changes between Version 21 and Version 24 of Ticket #28280


Ignore:
Timestamp:
10/16/19 08:32:41 (2 years ago)
Author:
gh-kliem
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28280

    • Property Dependencies changed from to #28605
    • Property Branch changed from public/28280 to
    • Property Milestone changed from sage-8.9 to sage-9.0
    • Property Commit changed from 9d506b820f1c245b5f6ca769506d2ae58a47095e to
    • Property Type changed from enhancement to task
  • Ticket #28280 – Description

    v21 v24  
    1 Replace attributes in `CombinatorialPolyhedron` by methods, such that they can potentially be lazily evaluated.
     1We make some changes to `CombinatorialPolyhedron` for it to be more consistent and suitable as a base class for `Polyhedron_base`.
    22
    3 This is motivated by #10777.
     3- #28605: Replace attributes in `CombinatorialPolyhedron` by methods, such that they can potentially be lazily evaluated.
     4  This is motivated by #10777.
     5  Also get rid of empty folder in source.
     6- #28603: `edge_graph` -> `vertex_graph`.
     7- #28604: `ridge_graph` -> `facet_graph`.
     8- #28606: `unbounded(self)` -> `is_bounded(self)`.
     9- #28614: `length_*` -> `n_*`.
     10- #28616: Replace `Vrepr()` and `Hrepr` by more consistent methods in `CombinatorialFace`.
     11- #28608: `repr` -> `rep` when abbreviating.
     12- #28607: Make `f_vector` a vector.
     13- #28613: Replace `V` and `H` by more meaningful attributes/methods.
     14- #28615: Finally fix some block alignment in `base.pxd`
    415
    5 While at it, we will change some names of methods for consistency:
    6 
    7 We make `CombinatorialPolyhedron` more consistent with `Polyhedron_base`, most importantly:
    8 - `edge_graph` -> `vertex_graph`,
    9 - `ridge_graph` -> `facet_graph`,
    10 - `unbounded(self)` -> `is_bounded(self)`,
    11 - `length_Hrep` -> `n_Hrepresentation`,
    12 - `length_Hrep` -> `n_Hrepresentation`.
    13 
    14 For `CombinatorialFace` we do the following changes:
    15 - `face.Vrep(True)` -> `face.ambient_Vrepresentation()`, `face.Vrep(False)` -> `face.ambient_V_indices()`,
    16 - `n_Vrepresentation` -> `n_ambient_Vrepresentation`,
    17 - the above applied to `Hrep`.
    18 
    19 We also delete `.cc` in the module name of `bit_vector_operations`. The `.cc` lead to an empty folder in the source directory. Without this folder does not reappear.
    20 
    21 In addition we do some minor bug fixing and some improvement in the documentation.
     16Some of the tickets also take care of minor bug fixes or typos.