Changes between Version 15 and Version 21 of Ticket #28280


Ignore:
Timestamp:
09/12/19 21:07:12 (2 years ago)
Author:
gh-kliem
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28280

    • Property Status changed from needs_review to needs_work
    • Property Summary changed from CombinatorialPolyhedron: replace attributes by methods to CombinatorialPolyhedron: replace attributes by methods, make names more consistent with Polyhedron
    • Property Commit changed from d02dee5ee83f3c5a35237da7afa3440f28f47307 to 9d506b820f1c245b5f6ca769506d2ae58a47095e
  • Ticket #28280 – Description

    v15 v21  
    33This is motivated by #10777.
    44
    5 While at it, we will change some names of methods of `CombinatorialPolyhedron` to be consistent with `Polyhedron_base`, or to be more meaningful.
     5While at it, we will change some names of methods for consistency:
     6
     7We make `CombinatorialPolyhedron` more consistent with `Polyhedron_base`, most importantly:
     8- `edge_graph` -> `vertex_graph`,
     9- `ridge_graph` -> `facet_graph`,
     10- `unbounded(self)` -> `is_bounded(self)`,
     11- `length_Hrep` -> `n_Hrepresentation`,
     12- `length_Hrep` -> `n_Hrepresentation`.
     13
     14For `CombinatorialFace` we do the following changes:
     15- `face.Vrep(True)` -> `face.ambient_Vrepresentation()`, `face.Vrep(False)` -> `face.ambient_V_indices()`,
     16- `n_Vrepresentation` -> `n_ambient_Vrepresentation`,
     17- the above applied to `Hrep`.
     18
     19We also delete `.cc` in the module name of `bit_vector_operations`. The `.cc` lead to an empty folder in the source directory. Without this folder does not reappear.
     20
     21In addition we do some minor bug fixing and some improvement in the documentation.