Opened 3 years ago

Closed 6 months ago

#28263 closed enhancement (fixed)

Degree for Affine Morphism or Affine Dynamical System

Reported by: gh-jl0128 Owned by:
Priority: minor Milestone: sage-9.7
Component: dynamics Keywords: SI2019, sd104
Cc: Ben Hutz Merged in:
Authors: Anna Chlopecki, Juliano Levier-Gomes, Adam Towsley, Alexander Galarraga, Jing Guo Reviewers: Julia Cai, Jasmine Camero, Olivia Schwager, A. S. Dasher, Ben Hutz
Report Upstream: N/A Work issues:
Branch: beb6f38 (Commits, GitHub, GitLab) Commit: beb6f38eccbe16b75baa7b1a2a0e636d2e656501
Dependencies: Stopgaps:

Status badges

Description

We wish to add a function that returns the degree of an affine morphism or an affine dynamical system.

Change History (39)

comment:1 Changed 3 years ago by Anna Chlopecki

Branch: u/gh-annanc2/new_test

comment:2 Changed 3 years ago by Anna Chlopecki

Commit: e649e4e2508c6a37cccb871fbd7b3b08cc41aa02
Summary: Degree for Affine Dynamical SystemDegree for Affine Dynamical System or Affine Morphism

New commits:

e649e4e28263 : Added a degree function for dynamical systems and affine morphisms.

comment:3 Changed 3 years ago by Anna Chlopecki

Summary: Degree for Affine Dynamical System or Affine MorphismDegree for Affine Morphism or Affine Dynamical System

comment:4 Changed 3 years ago by Anna Chlopecki

Status: newneeds_review

comment:5 Changed 3 years ago by gh-juliacai05

Branch: u/gh-annanc2/new_testu/gh-juliacai05/28263_aff_deg
Commit: e649e4e2508c6a37cccb871fbd7b3b08cc41aa02b5042327245e5528cc61f7470bfe9025faded4e1

fix merge conflict


New commits:

b504232Merge branch 8.9.beta4 of git://trac.sagemath.org/sage into 28263

comment:6 Changed 3 years ago by gh-oliviaschwager

Reviewers: Julia Cai, Jasmine Camero, Olivia Schwager
Status: needs_reviewpositive_review

comment:7 Changed 3 years ago by Volker Braun

Merge conflict, please merge in the next beta

comment:8 Changed 3 years ago by Volker Braun

Status: positive_reviewneeds_work

comment:9 Changed 3 years ago by Adam Towsley

Branch: u/gh-juliacai05/28263_aff_degu/atowsley/28263_aff_deg

comment:10 Changed 3 years ago by Adam Towsley

Commit: b5042327245e5528cc61f7470bfe9025faded4e1f36f1f13ca1945e14aeb0c9f359ecb7fc0718bc0
Status: needs_workneeds_review

Removed redundant code from dynamics and fixed the merge conflict.


New commits:

f36f1f1Merge branch 9.0beta5 into 28263

comment:11 Changed 3 years ago by Adam Towsley

Authors: Anna Chlopecki, Juliano Levier-GomesAnna Chlopecki, Juliano Levier-Gomes, Adam Towsley

comment:12 Changed 3 years ago by git

Commit: f36f1f13ca1945e14aeb0c9f359ecb7fc0718bc04dde62c9bb828ee199f058000705ce392aeefc81

Branch pushed to git repo; I updated commit sha1. New commits:

4dde62cAdded degree for dynamical systems using the affine morphism code

comment:13 Changed 3 years ago by Adam Towsley

Keywords: sd104 added

comment:14 Changed 3 years ago by gh-adasher

Status: needs_reviewpositive_review

comment:15 Changed 3 years ago by Frédéric Chapoton

Milestone: sage-8.9sage-9.0

comment:16 Changed 3 years ago by Frédéric Chapoton

Status: positive_reviewneeds_work

Please use "Return" and not "Returns".

Also, what is this piece of code doing ? Only the last line is used...

+        polys = self._polys
+        max_degree = 0
+        for poly in polys:
+            if poly.degree() > max_degree:
+                max_degree = poly.degree()
+        return self.as_scheme_morphism().degree()

comment:17 Changed 3 years ago by git

Commit: 4dde62c9bb828ee199f058000705ce392aeefc81ca91329c98fd901e0008257f9b7d740103d22e47

Branch pushed to git repo; I updated commit sha1. New commits:

ca91329Cleanup unused code, fix typos

comment:18 Changed 3 years ago by Adam Towsley

Status: needs_workneeds_review

I thought I had deleted that code. It's gone now.

comment:19 Changed 3 years ago by gh-adasher

Reviewers: Julia Cai, Jasmine Camero, Olivia SchwagerJulia Cai, Jasmine Camero, Olivia Schwager, A. S. Dasher
Status: needs_reviewpositive_review

comment:20 Changed 3 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict, please wait for the next beta and merge it in.

comment:21 Changed 3 years ago by Erik Bray

Milestone: sage-9.0sage-9.1

Ticket retargeted after milestone closed

comment:22 Changed 3 years ago by Matthias Köppe

Milestone: sage-9.1sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:23 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.3

comment:24 Changed 22 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:25 Changed 17 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

Setting a new milestone for this ticket based on a cursory review.

comment:26 Changed 16 months ago by Alexander Galarraga

Branch: u/atowsley/28263_aff_degu/gh-EnderWannabe/28263_aff_deg

comment:27 Changed 16 months ago by Alexander Galarraga

Commit: ca91329c98fd901e0008257f9b7d740103d22e4790f093cfe2388f94e70273413603f32ae90665db
Status: needs_workneeds_review

New commits:

90f093cMerge branch 'u/atowsley/28263_aff_deg' of git://trac.sagemath.org/sage into 28263

comment:28 Changed 16 months ago by Alexander Galarraga

Authors: Anna Chlopecki, Juliano Levier-Gomes, Adam TowsleyAnna Chlopecki, Juliano Levier-Gomes, Adam Towsley, Alexander Galarraga

comment:29 Changed 16 months ago by Alexander Galarraga

Cc: Ben Hutz added

comment:30 Changed 16 months ago by Ben Hutz

Reviewers: Julia Cai, Jasmine Camero, Olivia Schwager, A. S. DasherJulia Cai, Jasmine Camero, Olivia Schwager, A. S. Dasher, Ben Hutz
Status: needs_reviewneeds_work

This code works fine for polynomials, but affine maps can be rational...

A.<x,y>=AffineSpace(QQ,2)
f=DynamicalSystem_affine([x,y/(1+x^2)])
f.degree()

comment:31 Changed 12 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:32 Changed 8 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:33 Changed 6 months ago by Jing Guo

Authors: Anna Chlopecki, Juliano Levier-Gomes, Adam Towsley, Alexander GalarragaAnna Chlopecki, Juliano Levier-Gomes, Adam Towsley, Alexander Galarraga, Jing Guo

comment:34 Changed 6 months ago by Jing Guo

Branch: u/gh-EnderWannabe/28263_aff_degu/gh-guojing0/28263_aff_deg
Commit: 90f093cfe2388f94e70273413603f32ae90665dbef911bc5cd50cf5a23d2aee2751237e4b407ab6d

New commits:

ef911bcSupport for rational affine maps and a new test

comment:35 Changed 6 months ago by git

Commit: ef911bc5cd50cf5a23d2aee2751237e4b407ab6d91c0ea4f69c419ca8b499ac4d76a6e457ad2f950

Branch pushed to git repo; I updated commit sha1. New commits:

91c0ea4Add some space

comment:36 Changed 6 months ago by git

Commit: 91c0ea4f69c419ca8b499ac4d76a6e457ad2f950beb6f38eccbe16b75baa7b1a2a0e636d2e656501

Branch pushed to git repo; I updated commit sha1. New commits:

1997b17arithmetic_dynamics/affine_ds.py: Fix small spacing issue
beb6f38affine_ds.py: Small spacing issue

comment:37 Changed 6 months ago by Ben Hutz

Status: needs_workneeds_review

Remember to change to "needs-review" when ready.

comment:38 Changed 6 months ago by Ben Hutz

Status: needs_reviewpositive_review

Looks good.

Tests pass and docs build.

comment:39 Changed 6 months ago by Volker Braun

Branch: u/gh-guojing0/28263_aff_degbeb6f38eccbe16b75baa7b1a2a0e636d2e656501
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.