#28253 closed defect (fixed)

Fixing method "is_SPP()" for plane partition

Reported by: gh-erikapirnes Owned by:
Priority: major Milestone: sage-8.9
Component: combinatorics Keywords: plane partitions, days99
Cc: jessicapalencia, kdilks, gh-JoeBernstein, dyheuer Merged in:
Authors: Erika Pirnes Reviewers: Kevin Dilks
Report Upstream: N/A Work issues:
Branch: 26b31fa (Commits, GitHub, GitLab) Commit: 26b31fa0fe8790e71f67f363146ab126d0522300
Dependencies: Stopgaps:

Status badges

Description

For some plane partitions PP, the method PP.is_SPP() was giving false positives and for some others it was giving an error (index out of range). This was fixed by copying the z-tableau into a new square table. New test cases were added to both is_SPP() and is_SSCPP().

Change History (7)

comment:1 Changed 22 months ago by gh-erikapirnes

  • Keywords days99 added

comment:2 Changed 22 months ago by jessicapalencia

  • Branch set to u/jessicapalencia/fixisSPP
  • Commit set to 95ea5f39d99a911f564d8dcd5e7c184cd2be72e2

comment:3 Changed 22 months ago by git

  • Commit changed from 95ea5f39d99a911f564d8dcd5e7c184cd2be72e2 to 580979d36cfe85d1f785f14a668a216ccbaa3e33

Branch pushed to git repo; I updated commit sha1. New commits:

580979dfix to is_SPP code and tests added to is_SPP and is_SSCPP

comment:4 Changed 22 months ago by jessicapalencia

  • Status changed from new to needs_review

comment:5 Changed 22 months ago by kdilks

  • Branch changed from u/jessicapalencia/fixisSPP to u/kdilks/fixisSPP

comment:6 Changed 22 months ago by kdilks

  • Commit changed from 580979d36cfe85d1f785f14a668a216ccbaa3e33 to 26b31fa0fe8790e71f67f363146ab126d0522300
  • Reviewers set to Kevin Dilks
  • Status changed from needs_review to positive_review

Looks good to me.


New commits:

969f0a9Merge branch 'u/jessicapalencia/fixisSPP' of git://trac.sagemath.org/sage into 28253IsSPP
26b31faRemoved some doctests

comment:7 Changed 22 months ago by vbraun

  • Branch changed from u/kdilks/fixisSPP to 26b31fa0fe8790e71f67f363146ab126d0522300
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.