Opened 3 years ago
Closed 3 years ago
#28240 closed enhancement (fixed)
Move rational methods of the backend normaliz to the `_QQ` class
Reported by: | jipilab | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.9 |
Component: | geometry | Keywords: | polytopes, normaliz, days100 |
Cc: | jipilab, mkoeppe, vdelecroix, chapoton | Merged in: | |
Authors: | Jean-Philippe Labbé | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 436dbc3 (Commits, GitHub, GitLab) | Commit: | 436dbc30222da8559c7280e4f8cf3828c0d6eebb |
Dependencies: | Stopgaps: |
Description
Now that the normaliz backend allows algebraic values, it makes sense to move the rational polyhedral methods to the rational base class.
Change History (7)
comment:1 Changed 3 years ago by
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
comment:3 Changed 3 years ago by
- Commit changed from 436dbc30222da8559c7280e4f8cf3828c0d6eebb to 7b4318d108390722236fcbd37f7bfbe4f5f36195
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
7b4318d | pyflakes
|
comment:4 Changed 3 years ago by
OOps!!! My bad! Wrong branch!
comment:5 Changed 3 years ago by
- Commit changed from 7b4318d108390722236fcbd37f7bfbe4f5f36195 to 436dbc30222da8559c7280e4f8cf3828c0d6eebb
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
comment:6 Changed 3 years ago by
- Status changed from needs_review to positive_review
comment:7 Changed 3 years ago by
- Branch changed from u/jipilab/move_norm_features to 436dbc30222da8559c7280e4f8cf3828c0d6eebb
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
The Ehrhart polynomial business is going to be taken care of in #18957.