Opened 3 years ago

Closed 3 years ago

#28239 closed defect (fixed)

Precision of Laurent series is restricted to be positive

Reported by: Sebastian Oehms Owned by:
Priority: major Milestone: sage-9.1
Component: algebra Keywords: Laurent series precision days100
Cc: Travis Scrimshaw Merged in:
Authors: Sebastian Oehms Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 14878d5 (Commits, GitHub, GitLab) Commit: 14878d5c2b583966e842214f0b0438921d21516b
Dependencies: Stopgaps:

Status badges

Description

The problem occured in context with #4618 (see comment 32) and is explained by the following code:

sage: L.<x> = LaurentSeriesRing(QQ)
sage: q = x^2 + x^3
sage: q.add_bigoh(-1)
Traceback (most recent call last):
...
ValueError: prec (= -3) must be non-negative

Change History (7)

comment:1 Changed 3 years ago by Erik Bray

Milestone: sage-8.9sage-9.1

Ticket retargeted after milestone closed

comment:2 Changed 3 years ago by Sebastian Oehms

Branch: u/soehms/neg_prec_laurent_series_28239

comment:3 Changed 3 years ago by Sebastian Oehms

Authors: Sebastian Oehms
Cc: Travis Scrimshaw added
Commit: 9a3554134e426243c12a6aec7cac9ea71fb1ed97
Status: newneeds_review

Just changed one line of code.


New commits:

9a3554128239: initial version

comment:4 Changed 3 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

Can we also add sage: (t^(-2)).add_bigoh(-2) and remove the full-stop/period at the end of the INPUT: line. Once done, you can set a positive review.

comment:5 Changed 3 years ago by git

Commit: 9a3554134e426243c12a6aec7cac9ea71fb1ed9714878d5c2b583966e842214f0b0438921d21516b

Branch pushed to git repo; I updated commit sha1. New commits:

14878d528239: fix according to review

comment:6 Changed 3 years ago by Sebastian Oehms

Status: needs_reviewpositive_review

comment:7 Changed 3 years ago by Volker Braun

Branch: u/soehms/neg_prec_laurent_series_2823914878d5c2b583966e842214f0b0438921d21516b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.