Opened 3 years ago

Closed 3 years ago

#28236 closed enhancement (fixed)

add a way to restrict an index face set

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.9
Component: graphics Keywords: plot3d, days100
Cc: jipilab Merged in:
Authors: Frédéric Chapoton Reviewers: Thierry Coulbois, Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: f65a5ce (Commits, GitHub, GitLab) Commit: f65a5ce1a8325070d777e75d86c29c5465051828
Dependencies: Stopgaps:

Status badges

Description

in order to get the intersection with a domain in space

Attachments (1)

sombrero.png (30.7 KB) - added by chapoton 3 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28236
  • Commit set to 66b342215a2576032aa9f7a0a5a7709c72f944c4
  • Status changed from new to needs_review

New commits:

66b3422new method to cut surfaces along condition

comment:2 Changed 3 years ago by git

  • Commit changed from 66b342215a2576032aa9f7a0a5a7709c72f944c4 to d582409a738e6b29d9274dda8f464bc4459a8b75

Branch pushed to git repo; I updated commit sha1. New commits:

d582409trac 28236 add missing documentation

comment:3 Changed 3 years ago by chapoton

  • Keywords plot3d days100 added

comment:4 Changed 3 years ago by git

  • Commit changed from d582409a738e6b29d9274dda8f464bc4459a8b75 to f08d3347a7fedc29781c959ee6ed9e2818825c2b

Branch pushed to git repo; I updated commit sha1. New commits:

f08d334trac 28236 fix doc typo

comment:5 follow-up: Changed 3 years ago by chapoton

  • Cc jipilab added

Voilà !

comment:6 in reply to: ↑ 5 Changed 3 years ago by jipilab

Replying to chapoton:

Voilà !

Ok! Je regarde ça!

Changed 3 years ago by chapoton

comment:7 follow-up: Changed 3 years ago by chapoton

Here is what one can get (useful for heat waves)

Last edited 3 years ago by chapoton (previous) (diff)

comment:8 in reply to: ↑ 7 Changed 3 years ago by jipilab

Replying to chapoton:

Here is what one can get (useful for heat waves)

... so true! Or to use as a fan in a train with broken A/C.

Have you done the replacement between v and w? Should I test it again?

comment:9 Changed 3 years ago by git

  • Commit changed from f08d3347a7fedc29781c959ee6ed9e2818825c2b to 44dc20de7a290f8a0018e67630f564c4b0fb6793

Branch pushed to git repo; I updated commit sha1. New commits:

44dc20dtrac 28236 fix mistake

comment:10 Changed 3 years ago by chapoton

voila, j'avais oublié de pousser..

comment:11 follow-up: Changed 3 years ago by chapoton

t'as vraiment un train sans air conditionné ?

comment:12 Changed 3 years ago by coulbois

Patchbot finds a failed test (due to previous convention on weighted sum)

sage -t --long src/sage/plot/plot3d/index_face_set.pyx
**********************************************************************
File "src/sage/plot/plot3d/index_face_set.pyx", line 225, in sage.plot.plot3d.index_face_set.midpoint
The Patchbot find a failed doc-test (due to previous convention for weighted sum of points):

Failed example:
    midpoint((1,2,3),(4,4,4),0.8)
Expected:
    (3.40000000000000, 3.60000000000000, 3.80000000000000)
Got:
    (1.60000000000000, 2.40000000000000, 3.20000000000000)
**********************************************************************
1 item had failures:
   1 of   3 in sage.plot.plot3d.index_face_set.midpoint
    [152 tests, 1 failure, 5.60 s]

Last edited 3 years ago by coulbois (previous) (diff)

comment:13 Changed 3 years ago by git

  • Commit changed from 44dc20de7a290f8a0018e67630f564c4b0fb6793 to f65a5ce1a8325070d777e75d86c29c5465051828

Branch pushed to git repo; I updated commit sha1. New commits:

f65a5cetrac 28236 more fixes and doc

comment:14 Changed 3 years ago by chapoton

ok, doctest fixed and a little documentation added

comment:15 Changed 3 years ago by coulbois

  • Reviewers set to Thierry Coulbois

Positive review if when patchbot is green (sorry my sage is compiling).

SageDays? 100

comment:16 in reply to: ↑ 11 Changed 3 years ago by jipilab

Replying to chapoton:

t'as vraiment un train sans air conditionné ?

Ouais, il a brisé! C'était fantastique!

comment:17 Changed 3 years ago by jipilab

  • Status changed from needs_review to positive_review

comment:18 Changed 3 years ago by chapoton

  • Reviewers changed from Thierry Coulbois to Thierry Coulbois, Jean-Philippe Labbé

merci ! J'imagine bien la galère dans le train, et je compatis...

comment:19 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28236 to f65a5ce1a8325070d777e75d86c29c5465051828
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.