Opened 3 years ago

Closed 3 years ago

#28235 closed enhancement (fixed)

py3: polyhedron folder with optional packages

Reported by: jipilab Owned by:
Priority: major Milestone: sage-8.9
Component: python3 Keywords: geometry, py3, polyhedron, days100
Cc: jipilab, mkoeppe, vdelecroix, chapoton Merged in:
Authors: Jean-Philippe Labbé Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 846069d (Commits, GitHub, GitLab) Commit: 846069df88fce2a461613c6fdedbed3a52e924c9
Dependencies: Stopgaps:

Status badges

Description (last modified by jipilab)

There are 7 failing doctests in base.py using optional packages (latte_int and lrslib): 

----------------------------------------------------------------------
sage -t src/sage/geometry/polyhedron/base.py  # 7 doctests failed
sage -t src/sage/geometry/polyhedron/base_ZZ.py  # 1 doctest failed
----------------------------------------------------------------------

This tickets fixes them. The remaining packages are 'polymake' and 'polytopes_db_4d', which are experimental or not yet known status (see #26029).

Change History (8)

comment:1 Changed 3 years ago by jipilab

  • Branch set to public/28235
  • Commit set to d3dc7aacd9bb31d4fabc3a141d0f01d817868287
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​d3dc7aafix py3 in base.py with optional packages

comment:2 Changed 3 years ago by jipilab

  • Description modified (diff)

comment:3 Changed 3 years ago by git

  • Commit changed from d3dc7aacd9bb31d4fabc3a141d0f01d817868287 to c69d74fe5fc82499931512aac25a0445d7053a15

Branch pushed to git repo; I updated commit sha1. New commits:

​c69d74fmoved the import statement

comment:4 Changed 3 years ago by jipilab

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

... received the green light from chapoton.

comment:5 Changed 3 years ago by git

  • Commit changed from c69d74fe5fc82499931512aac25a0445d7053a15 to e5ecbcfe881529f22ba9cffa861bd0a1ee9e3105
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​e5ecbcfpyflakes

comment:6 Changed 3 years ago by git

  • Commit changed from e5ecbcfe881529f22ba9cffa861bd0a1ee9e3105 to 846069df88fce2a461613c6fdedbed3a52e924c9

Branch pushed to git repo; I updated commit sha1. New commits:

​846069dpyflakes-bis

comment:7 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

allons-y

comment:8 Changed 3 years ago by vbraun

  • Branch changed from public/28235 to 846069df88fce2a461613c6fdedbed3a52e924c9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.