Opened 2 years ago

Closed 2 years ago

#28229 closed enhancement (fixed)

Generalized shifted prime tableau

Reported by: gh-ChamanAgrawal Owned by:
Priority: major Milestone: sage-8.9
Component: combinatorics Keywords: gsocRSK
Cc: tscrim, darij Merged in:
Authors: Chaman Agrawal Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 053f926 (Commits, GitHub, GitLab) Commit: 053f9265c932863bb154cc4502e41ead547700d9
Dependencies: Stopgaps:

Status badges

Description

The generalized shifted prime tableau defined by BRUCE E. SAGAN is similar to the already existing shifted prime tableau in SageMath except for the fact that we can also have primed entries in the main diagonal. More details can be found here https://users.math.msu.edu/users/sagan/Papers/Old/sts-pub.pdf

Change History (20)

comment:1 Changed 2 years ago by gh-ChamanAgrawal

  • Branch set to u/gh-ChamanAgrawal/28229_generalizedShiftedTableau
  • Commit set to c76c98eaebf0f604eb4f94aedaf215f795dc27c6

Last 10 new commits:

288099bAdd preprocess in super tableax
5f302baAdd docs and test for super tableax
103c2fdComplete minimal semistandard and standard super tableaux
e53e9a8Merge branch 'temp_superRSK' into u/gh-ChamanAgrawal/24894_superRSK
05cb2f0Separate superTableau from tableau
5b622ebChange doctest
ff3829dDoc changes
90386bdMinor correction
2216bc1Minor correction 2
c76c98estart generalized shifted tableau

comment:2 Changed 2 years ago by git

  • Commit changed from c76c98eaebf0f604eb4f94aedaf215f795dc27c6 to 3696c813a07b0de53f258e139191a8ef2d1a9f7d

Branch pushed to git repo; I updated commit sha1. New commits:

fbdd6b3Debugging
88b1a86temparary changes for understanding __iter__
3696c81Implement __iter__ (not verified)

comment:3 Changed 2 years ago by git

  • Commit changed from 3696c813a07b0de53f258e139191a8ef2d1a9f7d to 244c63a778cba3f674c8609a45508aefeb94ac84

Branch pushed to git repo; I updated commit sha1. New commits:

30ddb9aSome test changed
244c63aMerge branch 'develop' into u/gh-ChamanAgrawal/28229_generalizedShiftedTableau

comment:4 Changed 2 years ago by git

  • Commit changed from 244c63a778cba3f674c8609a45508aefeb94ac84 to 0ebe56763d6388bef171453dd6460821239ca473

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0ebe567Cleaned branch and currently debugging for max_entry tableau listing

comment:5 Changed 2 years ago by git

  • Commit changed from 0ebe56763d6388bef171453dd6460821239ca473 to 312e2779c59d098c63c36d2acd73cd71e7631e87

Branch pushed to git repo; I updated commit sha1. New commits:

312e277Added shiftedTableau with max_entry

comment:6 Changed 2 years ago by git

  • Commit changed from 312e2779c59d098c63c36d2acd73cd71e7631e87 to 0064177b8e085be2fd3fac5786491defa12b6e69

Branch pushed to git repo; I updated commit sha1. New commits:

0064177Documentation changes

comment:7 Changed 2 years ago by gh-ChamanAgrawal

  • Branch changed from u/gh-ChamanAgrawal/28229_generalizedShiftedTableau to u/gh-ChamanAgrawal/28229_generalizedShiftedTableaux
  • Commit changed from 0064177b8e085be2fd3fac5786491defa12b6e69 to 17ed64d54d32af82d201629f6a1b91ed3bfc4612

New commits:

17ed64dAdd option for primed entry in main diagonal

comment:8 Changed 2 years ago by git

  • Commit changed from 17ed64d54d32af82d201629f6a1b91ed3bfc4612 to 82dda1503a128a78533310ee6b756d2e4746298f

Branch pushed to git repo; I updated commit sha1. New commits:

82dda15Add more tests and documentation changes

comment:9 Changed 2 years ago by gh-ChamanAgrawal

  • Cc darij added
  • Status changed from new to needs_review

comment:10 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to needs_work

Python variable naming conventions: primedDiagonal -> primed_diagonal. However, the primed diagonal is something that is stored with the parent, so it should not also be stored with the element. So you can get it with self.parent()._primed_diagonal.

The __iter__ EXAMPLES:: needs a blankline after it.

comment:11 Changed 2 years ago by git

  • Commit changed from 82dda1503a128a78533310ee6b756d2e4746298f to 958a89322abd8c251249fdd798470a7a71afb762

Branch pushed to git repo; I updated commit sha1. New commits:

6995c3bMerge branch 'develop' into u/gh-ChamanAgrawal/28229_generalizedShiftedTableaux
958a893Change variable name

comment:12 Changed 2 years ago by git

  • Commit changed from 958a89322abd8c251249fdd798470a7a71afb762 to 805289c03100cd2143851504cd400fee815f9299

Branch pushed to git repo; I updated commit sha1. New commits:

805289cRemoved redundant initialization

comment:13 Changed 2 years ago by git

  • Commit changed from 805289c03100cd2143851504cd400fee815f9299 to 5c2b79c7d8dc320d18438b03302646b6f429e720

Branch pushed to git repo; I updated commit sha1. New commits:

5c2b79cRemove _primed_diagonal from element class

comment:14 Changed 2 years ago by git

  • Commit changed from 5c2b79c7d8dc320d18438b03302646b6f429e720 to b1912ca6f3fb301039ae898bdf6521c156de8a74

Branch pushed to git repo; I updated commit sha1. New commits:

b1912caMinor documentation changes

comment:15 Changed 2 years ago by gh-ChamanAgrawal

  • Status changed from needs_work to needs_review

comment:16 Changed 2 years ago by gh-ChamanAgrawal

  • Milestone changed from sage-feature to sage-8.9

comment:17 Changed 2 years ago by git

  • Commit changed from b1912ca6f3fb301039ae898bdf6521c156de8a74 to 7a30231f2354844cb6fe5734a2044c56968b2276

Branch pushed to git repo; I updated commit sha1. New commits:

7a30231add is_standard() method

comment:18 Changed 2 years ago by tscrim

  • Branch changed from u/gh-ChamanAgrawal/28229_generalizedShiftedTableaux to u/tscrim/genearlize_shifted_prime_tableau-28229
  • Commit changed from 7a30231f2354844cb6fe5734a2044c56968b2276 to 053f9265c932863bb154cc4502e41ead547700d9

I have done some simple reviewer changes. If they are good, then positive review.


New commits:

325c912Merge branch 'u/gh-ChamanAgrawal/28229_generalizedShiftedTableaux' of git://trac.sagemath.org/sage into u/gh-ChamanAgrawal/28229_generalizedShiftedTableaux
053f926Doing some reviewer changes.

comment:19 Changed 2 years ago by gh-ChamanAgrawal

  • Status changed from needs_review to positive_review

comment:20 Changed 2 years ago by vbraun

  • Branch changed from u/tscrim/genearlize_shifted_prime_tableau-28229 to 053f9265c932863bb154cc4502e41ead547700d9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.