Changes between Initial Version and Version 11 of Ticket #28219


Ignore:
Timestamp:
Aug 27, 2019, 6:10:42 PM (3 years ago)
Author:
Markus Wageringel
Comment:

I have removed the patch from the branch, but kept the new doctest. This needs review again.


New commits:

1ad2bfb28219: add doctest for Pynac's rational hash function

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28219

    • Property Status changed from new to needs_review
    • Property Reviewers changed from to John Palmieri
    • Property Authors changed from to Markus Wageringel
    • Property Summary changed from patch pynac's rational and integer hash function to add a doctest for pynac's rational hash function
    • Property Dependencies changed from to #28412
    • Property Branch changed from to u/gh-mwageringel/28219v2
    • Property Report Upstream changed from N/A to Fixed upstream, in a later stable release.
    • Property Commit changed from to 1ad2bfbed1f67c4d35375173553fec56564a7374
  • Ticket #28219 – Description

    initial v11  
    1 The implementation of Pynac's `_mpz_pythonhash` and `_mpq_pythonhash` in `ginac/numeric.cpp` for integers and rationals in `SR` used to agree with the hash implementations in Sage. Since the implementations in Sage have changed, Pynac needs to be updated.
     1The upgrade to Pynac 0.7.26 #28412 resolves the following issues with hashes in `SR` . This ticket adds a doctest for this.
    22
    33This fails with Python 2 and 3: